• [C#] [1.1.0] Escape - A Console-Based RPG Like No Other
    35 replies, posted
[QUOTE=gonzalolog;42781187]Oh my god! This is really beautiful! (I had in my had what i was doing while i was tipyng) Really good job![/QUOTE] I'm glad you like it!
Whisperity on GitHub has just submitted a pull request to me with some excellent changes to my code. The next update might be a little bit because it will take me some time to review all the new code. Check it out here: [url]https://github.com/ryansworld10/Escape/pull/3[/url]
There's quite a bit of bad advice there though, the initialization through properties is really ugly and the hack with the EntryDatabase is awful. If you're hardcoding everything anyway put the item and enemy prototype/templates/whatever these are into public static readonly variables on some class like this: [code]public static Item Key = // Item definition here[/code] That way you don't have to use strings at all. [editline]11th November 2013[/editline] Seriously, some of this has Java levels of counter-productive decoupling. Never change a program to use identifiers if you can use references and constants/readonly fields instead. If you decide to switch do dynamic items later you can still lift everything from the static definitions without changes with about 5 lines of reflection. late [editline]edit[/editline] I'll explain this in a bit more detail soon-ish, so please bear with me for a bit. There are a few slightly more in depth things I want to mention, so it will take some time. I'm going to expand on whisperity's changes, so don't let me stop you from taking them into account. Especially the change to item "template" instances instead of classes is a very good idea.
I don't see any uniqueness here.
[QUOTE=Umbra Fidelis;42828980]I don't see any uniqueness here.[/QUOTE] That's partially because this is still quite early in development. I do have plans for some pretty unique things, but those will come once the core engine is done.
I've slowly started merging some changes from the new OOP-Restructure branch into the develop branch. Its taking me some time to learn some of the new coding techniques used.
Sorry, you need to Log In to post a reply to this thread.