[QUOTE=adamjon858;31194036][IMG]http://i.imgur.com/zvqPA.png[/IMG][/QUOTE]
I can see the glow cut off on the far left of "Local". Otherwise, neat. Good color scheme.
[QUOTE=spidersdesign;31191024]I've implemented jQuery style method chaining so my code now looks like:
[php]
include( dirname( __FILE__ ) ."/lava.php" );
$pluginName = "SD Privacy";
$pluginSlug = strtolower( str_replace( " ", "_", $pluginName ) );
$pluginVersion = "4.0 beta";
$sdPrivacy = lava::newPlugin( $pluginName, $pluginVersion );
$sdPrivacy->_settings() ->addSetting( "enabled" )
->type( "checkbox" )
->help( __( "Use this to enable or disable the plugin", $pluginSlug ) )
->default( "on" )
->addGroup( "passwords" )->groupName( __( "Configure password" ) )
->addSetting( "password" )
->type( "password" )
->help( __( "Password required by visitors to display site", $pluginSlug ) )
;
$sdPrivacy->_pages() ->addSettingsPage()
->addSkinsPage()
->title( __( "Login page skins", $pluginSlug ) )
->heading( __( "Select Login Page Skin", $pluginSlug ) )
->heading( __( "Configure Login Skin", $pluginSlug ), "configure" )
->addTablePage( "accesslogs" )
->title( __( "Access Logs", $pluginSlug ) )
->addSupportPage()
->addLicensingPage()
;
[/php]
And before someone asks - that isn't one class - it is loads of different ones:
lava
lavaPlugin - main plugin class (instance of it returned by lava::newPlugin )
lavaBase - base class that all classes (except lava and lavaPlugin) extend. It automagically gives the class access to all public methods of the lavaPlugin instance as if they were methods of the subclass (all lavaPlugin methods are prefixed with an underscore so no clashes occur
lavaSettings - instance returned by _settings() method, used for creating or fetching settings
lavaSettingsQuery - a class used for querying the settings to find (for example) all the options that are passwords within the group "network"
lavaSetting - class for each setting
lavaPages - instance returned by _pages() method, used to create pages and fetch them later for further manipulation
lavaPage - base class which all specialised pages extend
- lavaSettingsPage
- lavaSkinsPage
- lavaSupportPage
- lavaLicensingPage
- lavaTablePage
I have split the code into settings and pages purely for readability - the _pages() call could have been directly attached to the last setting chain. The way it works is after a Setting object is added or fetched with addSetting or fetchSetting respectively that setting instance is retrieved or stored (depending on whether adding or fetching) in an array of all setting instances and stored in the "current" property of the lavaBase class (because lavaBase handles all of this the code doesn't need to be put in all the classes) so when a method that doesn't exist is called it first checks whether the method exists on the plugins main instance (which is stored in the pluginInstance property of lavaBase) and if it is then it calls that and returns the result. If not it then checks the "current" instance that is being operated on. If the method doesn't exist there either it just returns itself (and logs an error). If it was found in the current instance then the method does its stuff and if it is a method that is a chaining method (some of them aren't like [php]get( "property" );[/php] which returns a value) it does [php]return $this->_settings( false );[/php] The false part tells it to not reset the "current" property (which it would if it wasn't there).[/QUOTE]
That indentation looks really messy.
[QUOTE=Jelly;31195093]That indentation looks really messy.[/QUOTE]
Facepunch usually messes up indentation.
[quote][URL="http://brettjones.me/i/soul-home.jpg"][IMG]http://brettjones.me/i/soul-home.jpg[/IMG][/URL][/quote]
[quote][URL="http://brettjones.me/i/soul-about.jpg"][IMG]http://brettjones.me/i/soul-about.jpg[/IMG][/URL][/quote]
Client Work.
Pretty stoked to be working for this client, they're responsible for quite a few memorable television commercials if you're a 90's kid living in Perth like I was. I'll be sending through two different proposed designs to the client tomorrow; heres two pages of the first design. Not completely happy with the home page, specifically, the bottom right testimonials. I might put the testimonials on another page and put the featured adverts bottom right opposite the client logos, because it looks a bit cluttered right now and doesn't quite work.
Oh and feedback more than welcome.
Dammit Brettjay you are the greatest
Next time I go to Perth to visit my aunt's grave you are welcome to come and participate in the inevitable drinking that will occur at my expense
The design's pretty awesome too, I love the background.
[QUOTE=BrettJay;31201643][img]http://brettjones.me/i/soul-home.jpg[/img][/QUOTE]
I really love this
[QUOTE=Jelly;31195093]That indentation looks really messy.[/QUOTE]
Suggestions?
How about:
[php]
$sdPrivacy
->_settings()
->addSetting( "enabled" )
->type( "checkbox" );
->addSetting( "password")
->_pages()
;
[/php]
[editline]19th July 2011[/editline]
Now this is sloppy:
[quote]
Version Description
5.3.0 This function is no longer deprecated, and will therefore no longer throw E_STRICT warnings.
5.0.0 This function became deprecated in favour of the instanceof operator. Calling this function will result in an E_STRICT warning.
[/quote]
[url]http://php.net/manual/en/function.is-a.php[/url]
[QUOTE=spidersdesign;31204585]Suggestions?
How about:
[php]
$sdPrivacy
->_settings()
->addSetting( "enabled" )
->type( "checkbox" );
->addSetting( "password")
->_pages()
;
[/php]
[editline]19th July 2011[/editline]
Now this is sloppy:
[url]http://php.net/manual/en/function.is-a.php[/url][/QUOTE]
I'd do:
[php]
$sdPrivacy->addSetting(array(
array('name' => 'enabled', 'type' => 'checkbox'),
array('name' => 'password')
));
[/php]
etc, but that's just me.
[QUOTE=spidersdesign;31204585]Now this is sloppy:
[url]http://php.net/manual/en/function.is-a.php[/url][/QUOTE]
php for ya
[QUOTE=Jelly;31204838]I'd do:
[php]
$sdPrivacy->addSetting(array(
array('name' => 'enabled', 'type' => 'checkbox'),
array('name' => 'password')
));
[/php]
etc, but that's just me.[/QUOTE]
I think my version (the second one - under "How about:") is more readable and easy to change later (don't have to think about anything like commas and arrays (although I did make a mistake in my code - semi colon shouldn't have been after "->type(...)" ).
I did this to Elliot's forum :v:
[img]http://gabrielecirulli.com/p/20110719-131421.png[/img]
Visit it, by the way:
[URL]http://runwithcode.com/index.php[/URL]
[QUOTE=TerabyteS_;31205850]I did this to Elliot's forum :v:
[img]http://gabrielecirulli.com/p/20110719-131421.png[/img]
Visit it, by the way:
[URL]http://runwithcode.com/index.php[/URL][/QUOTE]
Did this for or did this to?
I can't see that.
[editline]19th July 2011[/editline]
If I have a div that is 50px high and 150px wide and I have 4 50x50 divs inside that float left, the 4th div appears (well actually doesn't because overflow is hidden) below the container div rather than to the right. Can I, and if so how, make it always overflow to the right?
[QUOTE=BrettJay;31201643]Client Work.
Pretty stoked to be working for this client, they're responsible for quite a few memorable television commercials if you're a 90's kid living in Perth like I was. I'll be sending through two different proposed designs to the client tomorrow; heres two pages of the first design. Not completely happy with the home page, specifically, the bottom right testimonials. I might put the testimonials on another page and put the featured adverts bottom right opposite the client logos, because it looks a bit cluttered right now and doesn't quite work.
Oh and feedback more than welcome.[/QUOTE]
I love those buttons they look so tasty to eat.
[QUOTE=spidersdesign;31205925]Did this for or did this to?
I can't see that.
[/QUOTE]Well, both
[QUOTE=TerabyteS_;31206865]Well, both[/QUOTE]
I can't see it on the site
[QUOTE=spidersdesign;31206941]I can't see it on the site[/QUOTE]He went to sleep before he could change it. Is the stickman logo good or bad?
[QUOTE=BrettJay;31201643]Client Work.
Pretty stoked to be working for this client, they're responsible for quite a few memorable television commercials if you're a 90's kid living in Perth like I was. I'll be sending through two different proposed designs to the client tomorrow; heres two pages of the first design. Not completely happy with the home page, specifically, the bottom right testimonials. I might put the testimonials on another page and put the featured adverts bottom right opposite the client logos, because it looks a bit cluttered right now and doesn't quite work.
Oh and feedback more than welcome.[/QUOTE]
Heh, you're all over Droid Sans :P
I really like this design. Did they give you the logo or did you design it as well? If so, nice font contrast!
A few critiques:
• The shadowing on the thumbnails is a bit excessive, lighten the opacity slightly and lower the distance
• Try playing around with adding a thin 1 to 3 px line the same color of the buttons underneath the header to separate it from the content.
• I'm not sure how this would look, but experiment with adding a shadow to the video box. I might be wrong but I think it'll help give the page a little more depth.
• The only thing I don't really like about the design is the button shape. They're just too rounded to co-exist with all the square/rectangle media. I think if you square them up a bit you'd achieve design perfection.
Other than that, designgasm.
[b]WHY IS THE LIST BBCODE BROKEN :( [/b]
[QUOTE=adamjon858;31208356]
[b]WHY IS THE LIST BBCODE BROKEN :( [/b][/QUOTE]
[B]LIST BBCODE™[/B] is available for 4.95$ at the [B]Facepunch Store™[/B]
[QUOTE=StinkyJoe;31208857][B]LIST BBCODE™[/B] is available for 4.95$ at the [B]Facepunch Store™[/B][/QUOTE]
Rated dumb because that is simply retarded if true.
Garry removed it. Just use Alt + 7.
• List
• List
• Fuck
[editline]19th July 2011[/editline]
Garry removed it. Just use Alt + 7.
• List
• List
• Fuck
• But
• It's
• Not
• Indented
• :(
[editline]19th July 2011[/editline]
Seriously what's the point in removing all this shit from facepunch. I'm starting to dislike this.
TerabyteS_ - it's just garry's regular periods.
-snip-
Oh by the way, LESS.js is effing amazing. Really liking it. Guess I'll use only it from now on.
People found out a way to use [list][/list] to insert a rouge </ol> within the page. Since the posts are displayed as a list, this caused some pretty bad formatting errors.
[QUOTE=adamjon858;31208356]Heh, you're all over Droid Sans :P[/QUOTE]
I think you might be slightly more obsessed with that font, because this design doesn't actually use Droid Sans anywhere :v:
[QUOTE=adamjon858;31208356]I really like this design. Did they give you the logo or did you design it as well? If so, nice font contrast![/QUOTE]
Thanks; I designed the logotype; I intend for there to be a logo to go along with the particular font I've chosen for the logo, but I'm having some difficulty coming up with something simple, clear and memorable and relevant to soul films (without being too cliche'd). I have a few different logos that I'm kicking around, but nothing I'm particularly happy with yet.
[QUOTE=adamjon858;31208356]
• The shadowing on the thumbnails is a bit excessive, lighten the opacity slightly and lower the distance
• Try playing around with adding a thin 1 to 3 px line the same color of the buttons underneath the header to separate it from the content.
• I'm not sure how this would look, but experiment with adding a shadow to the video box. I might be wrong but I think it'll help give the page a little more depth.
• The only thing I don't really like about the design is the button shape. They're just too rounded to co-exist with all the square/rectangle media. I think if you square them up a bit you'd achieve design perfection.
[/QUOTE]
Great feedback, I think I agree on pretty much every point, besides perhaps button shape (for one thing, being the only rounded elements means they'll stick out contrast-wise, I suppose :v:), but I do see where you're coming from so I'll try changing the button shapes. Thanks for the feedback.
[QUOTE=BrettJay;31212287]I think you might be slightly more obsessed with that font, because this design doesn't actually use Droid Sans anywhere :v:
[/quote]
What font is used on the buttons? Trebuchet? It looks like droid sans :x
[quote]
Great feedback, I think I agree on pretty much every point, besides perhaps button shape (for one thing, being the only rounded elements means they'll stick out contrast-wise, I suppose :v:), but I do see where you're coming from so I'll try changing the button shapes. Thanks for the feedback.[/QUOTE]
I think the main thing with the buttons isn't so much the shape as it is the fact that they are bit small. Switching to a 5px rounded but keeping them the same shape would make them look a bit bigger. I see what you're trying to do with them, but it just feels like for being so important that bigger would suit them better.
[QUOTE=adamjon858;31212621]What font is used on the buttons? Trebuchet? It looks like droid sans :x[/QUOTE]
[url="http://en.wikipedia.org/wiki/PT_Sans"]Pt Sans[/url]. Very similar to Lucida Grande/Sans and Droid Sans, but not quite ;)
[QUOTE]I think the main thing with the buttons isn't so much the shape as it is the fact that they are bit small. Switching to a 5px rounded but keeping them the same shape would make them look a bit bigger. I see what you're trying to do with them, but it just feels like for being so important that bigger would suit them better.[/QUOTE]
That's true, I just didn't feel like large web 2.0 call to actions were necessarily appropriate (I think I also didn't want the buttons to drop too far below the video on the right.
[QUOTE=BrettJay;31201643]Client Work.
Pretty stoked to be working for this client, they're responsible for quite a few memorable television commercials if you're a 90's kid living in Perth like I was. I'll be sending through two different proposed designs to the client tomorrow; heres two pages of the first design. Not completely happy with the home page, specifically, the bottom right testimonials. I might put the testimonials on another page and put the featured adverts bottom right opposite the client logos, because it looks a bit cluttered right now and doesn't quite work.
Oh and feedback more than welcome.[/QUOTE]
Is it me or does that seem very clean and slick and robotic for a company that's trying to state that it has "soul"?
Sorry, you need to Log In to post a reply to this thread.