Web Development - WAYWO - #8 - Developers

[QUOTE=Goz3rr;41452828]Well from what i can see, they did no optimizing at all, JS and CSS aren't minified and images are way too big (and not compressed either) And who in their right mind would use javascript to define the content (bio.js)[/QUOTE] Not to mention the background images are hotlinked.

[QUOTE=TerabyteS_;41452677]I doubt that. Also, when you're on an internship you usually just have the full-time web developers telling you what you're supposed to be doing on day 1, and then leaving you on your own for the rest of the time to go back to work on their stuff, so they probably didn't have much direction during the whole project apart from probably talking to Gabe or someone else a few times.[/QUOTE] I'm a bit older than some of them and I can safely say that i'm embarrassed to be within the same age range as them.

I did have a look through the code at first announcement and thought the same thing, but I suppose you can't blame them, being 15. When I was 15 my code was pretty terrible.

By popular request a full breakdown will be coming tonight.

[QUOTE=JohnD;41457915]By popular request a full breakdown will be coming tonight.[/QUOTE] Make it constructive enough to send to Gabe, they'll appreciate it.

[QUOTE=JohnD;41457915]By popular request a full breakdown will be coming tonight.[/QUOTE] Neat! This will help me on what im doing too.

[QUOTE=Marlamin;41457932]Make it constructive.[/QUOTE] NO! Make them cry. That'll teach young people trying to do [i]things[/i]!

Spent a bunch of time this weekend working on spoonfedstyle.com again. First time in a few months that I've sunk any work in to it. My focus right now is on improving engagement/retention with users. I get a lot of people that sign up for the site after finding a product page from a google search and then never rate any products, so I've been building out stuff to automatically email people who haven't engaged with the site yet. I also built out a weekly email that sends 10 recommendations to everyone who has rated enough products to actually get recommendations to try to encourage people who have used the site to come back and use it more. Probably going to build a weekly "new stuff on the site" and "popular stuff on the site" email as well. Also considering an email that sends you 10 random products that you have previously liked to make sure people don't forget about cool things they find.

Part one is here: [url]http://johnduhart.github.io/breakdown/pipeline-one.html[/url] Expect more soon.

don't harass them and abuse their site they might actually learn from their mistakes

[QUOTE=JohnD;41470175]Part one is here: [url]http://johnduhart.github.io/breakdown/pipeline-one.html[/url] Expect more soon.[/QUOTE] Okay, that's definitely the wrong way to do that. [quote]In all seriousness though, given that these are teenagers as young as 15, I’m going to dull my bite quite a bit. They’re not professionals and it would be unfair to assume as such.[/quote] And then ending the blogpost with publishing a script to abuse their website? Yeah, no.

[QUOTE=Marlamin;41470689]Okay, that's definitely the wrong way to do that. And then ending the blogpost with publishing a script to abuse their website? Yeah, no.[/QUOTE] Removed the proof of concept but what else is wrong?

[QUOTE=JohnD;41470725]Removed the proof of concept but what else is wrong?[/QUOTE] That was my main gripe with your blog post. Thanks for removing the PoC. PS: You should look at some Valve websites if you think using is wrong. :v:

I got tired of not knowing what branch I am on in a Git repository so I modified my command prompt to show the current branch if I'm in a Git repo and, as a bonus, a red dot if there's uncommitted stuff. [img]http://pictures.gabrielecirulli.com/rails_tutorial_%E2%80%94_bash_%E2%80%94_bash_%E2%80%94_100%C3%9724-20130715-212206.png[/img]

[QUOTE=JohnD;41470175]Part one is here: [url]http://johnduhart.github.io/breakdown/pipeline-one.html[/url] Expect more soon.[/QUOTE] [quote=YourWebsite] although with a more professional tone. [/quote] And further down [quote=YourWebsite] lrn2padding [/quote] :v:

[QUOTE=commander204;41470828]And further down :v:[/QUOTE] heh

[QUOTE=Marlamin;41470787]PS: You should look at some Valve websites if you think using is wrong. :v:[/QUOTE] It is wrong, Valve doing it doesn't make it right.

Emoji version: [img]http://pictures.gabrielecirulli.com/sample_app_%E2%80%94_bash_%E2%80%94_bash_%E2%80%94_100%C3%9724-20130715-213158.png[/img]

[QUOTE=rieda1589;41470879]It is wrong, Valve doing it doesn't make it right.[/QUOTE] I'm not saying it makes it right, just that the pipeline website isn't the only Valve website with faults like these.

[QUOTE=rieda1589;41470879]It is wrong, Valve doing it doesn't make it right.[/QUOTE] It's still good to use inside of a text-based paragraph, there is absolutely no problem with that.

[QUOTE=JohnD;41470175]Part one is here: [url]http://johnduhart.github.io/breakdown/pipeline-one.html[/url] Expect more soon.[/QUOTE] Sorry to be that guy, but 5px isn't enough padding. lrn2padding

By the way here's a comparison that lets you see more easily what's wrong with the code. [url]https://gist.github.com/gabrielecirulli/98b3936ccb2da1cf7951[/url] Both pieces of code do the same thing, but one of the two does it in three lines instead of more than 30.

[QUOTE=JohnD;41470175]Part one is here: [url]http://johnduhart.github.io/breakdown/pipeline-one.html[/url] Expect more soon.[/QUOTE] tags aren't used anymore? then what's the alternative?

[QUOTE=Giraffen93;41471462] tags aren't used anymore? then what's the alternative?[/QUOTE] I did notice a few times they had used tags to try and drop a block level element below another, which is completely unnecessary. should only be used for text, as far as I know.

[QUOTE=Shadow801;41471491]I did notice a few times they had used tags to try and drop a block level element below another, which is completely unnecessary. should only be used for text, as far as I know.[/QUOTE] oh, didn't notice it was outside at first

[QUOTE=Giraffen93;41471462] tags aren't used anymore? then what's the alternative?[/QUOTE] is used, but not for this. You use in a paragraph when you want to go to a new line. You don't use to make space between elements. To make space between elements you use padding and margin.

It's all about that [I]display:block;[/I]

[QUOTE=TerabyteS_;41471397]By the way here's a comparison that lets you see more easily what's wrong with the code. [url]https://gist.github.com/gabrielecirulli/98b3936ccb2da1cf7951[/url] Both pieces of code do the same thing, but one of the two does it in three lines instead of more than 30.[/QUOTE] Wouldn't just .next(".answer") work instead of using the :eq selector?

[QUOTE=JohnD;41471722]Wouldn't just .next(".answer") work instead of using the :eq selector?[/QUOTE] No, because there's a between the two, and .next() will only check the first sibling that follows (the ) and stop, failing. My code actually used .next() at first, then I tested it and realized the was messing with it.

[QUOTE=TerabyteS_;41471798]No, because there's a between the two, and .next() will only check the first sibling that follows (the ) and stop, failing. My code actually used .next() at first, then I tested it and realized the was messing with it.[/QUOTE] Ah, true.