Console command = server crash

[Wenli]

Entering "test_workshop" in console will crash the server that you're on.

'nuff said.

[Drakehawke]

STEAM REMOTE STORAGE!!!!!!!!
steamengine.cpp (2077) : Assertion Failed: Narrowing inPtr to toClass returned NULL.
/home/buildbot/buildslave_steam/steam_rel_client_linux/build/src/clientdll/steamengine.cpp 2077 Assertion Failed: Narrowing inPtr to toClass returned NULL.

Serverside error when it crashes

[editline]28th October 2012[/editline]

Oh and it wont auto-restart either

[Drakehawke]

Bumping this, you can't get rid of this command at all, I've tried:

[lua]
concommand.Add( "test_workshop", function() end )
concommand.Remove( "test_workshop" )
[/lua]

Both serverside and clientside, nothing gets around it.

People are using this to maliciously crash servers everywhere :v:

[Kingof🅱east]

Adding on, you also can't concommand.Add then override concommand.Run

[Drakehawke]

[img]http://puu.sh/1jS2v[/img]

Wrote a quick binary to remove it since concommand.Remove/Add didn't work.

[editline]28th October 2012[/editline]

Windows version: [url]http://puu.sh/1jSSa[/url]

Save as gmsv_test_workshop_fix_win32.dll in garrysmod/lua/bin, require it serverside to remove it.

Source:

#define GMMODULE
#include "GarrysMod/Lua/Interface.h"

#include "tier1/tier1.h"
#include "tier1/interface.h"
#include "vstdlib/cvar.h"

GMOD_MODULE_OPEN()
{
	CreateInterfaceFn tier1Factory = VStdLib_GetICVarFactory();
	g_pCVar = (ICvar *)tier1Factory( CVAR_INTERFACE_VERSION, NULL );
	g_pCVar->UnregisterConCommand( g_pCVar->FindCommandBase( "test_workshop" ) );
	return 0;
}

Linux coming soon

[killslicks]

Was this tested on 64 bit windows ? i get Couldn't load module library!

[Drakehawke]

Yeah just fixed: [url]http://puu.sh/1jSSa[/url]

[killslicks]

Great job thanks

[Acecool]

Great job, thank you! I noticed one problem though, the server crashes upon reloading the current map using changelevel..

[Pantho]

Useful and awesome as ever drakehawke:)

[lorde banana]

linux, my love?

[BlackAwps]

You don't need a module to block this..

alias test_workshop ""

[lorde banana]

let drake have his moment!

[Betaetalade]

Thanks alot.

[spykr]

[QUOTE=BlackAwps;38227199]You don't need a module to block this..

alias test_workshop ""

[/QUOTE]

Needs to be run on the client, just putting it in my autoexec.cfg as suggested didn't work.

[Slayer3032]

[QUOTE=spykr;38232504]Needs to be run on the client, just putting it in my autoexec.cfg as suggested didn't work.[/QUOTE]

Then you probably did something dumb like save it as autoexec.cfg.txt

or didn't save it

[NaRyan]

[QUOTE=slayer3032;38232570]Then you probably did something dumb like save it as autoexec.cfg.txt

or didn't save it[/QUOTE]

Nope it does not work.
if you type the command via rcon it does nothing.
However if you type it in the client side console the server still crashes....

[spykr]

[QUOTE=slayer3032;38232570]Then you probably did something dumb like save it as autoexec.cfg.txt

or didn't save it[/QUOTE]

No, running alias server-side does nothing to the client.
Running alias on the client fixes it, but I'm assuming they can just use alias to set it again.

[gamerpaddy]

maybe lua?
[LUA]
hook.Add("PlayerInitalSpawn","fix test_workshit",function(p)
p:SendLua("RunConsoleCommand([[alias]],[[test_workshop]],[[disconnect]])")
end)
[/LUA]
sending "connect" command works, i dont know if this work..

edit: D: didnt work

[Wizard of Ass]

[QUOTE=gamerpaddy;38232668]maybe lua?
[LUA]
hook.Add("PlayerInitalSpawn","fix test_workshit",function(p)
p:SendLua("RunConsoleCommand([[alias]],[[test_workshop]],[[disconnect]])")
end
[/LUA]
sending "connect" command works, i dont know if this work..[/QUOTE]

No that won't work.

[Pantho]

Confirmed it is crashing server on map changes sadly, which is fine for most of my servers but not TTT ;)

[charlie c]

[QUOTE=Pantho;38232825]Confirmed it is crashing server on map changes sadly, which is fine for most of my servers but not TTT ;)[/QUOTE]

maybe u could solve that by changing it to another zombie RP server.

[NaRyan]

Grab the updated binaries from the SVN.
[url=http://www.facepunch.com/showthread.php?t=1221645&p=38232755&viewfull=1#post38232755]Garry has fixed it.[/url]

[Pantho]

[QUOTE=charlie c;38232835]maybe u could solve that by changing it to another zombie RP server.[/QUOTE]

Are you not bored of being banned from fp yet?

And thanks @NaRyan, already download it :)

[charlie c]

[QUOTE=Pantho;38232884]Are you not bored of being banned from fp yet?

And thanks @NaRyan, already download it :)[/QUOTE]

sorry for making a suggestions.