Need help on a simple lua code

[jonitah112]

Hi, im new at coding in lua and i have a little issue with my code :

function suicidio (victim, attacker)
	if ( victim == attacker ) then
		PrintMessage( HUD_PRINTTALK, victim:Name() .. " committed suicide." )
	else
		PrintMessage( HUD_PRINTTALK, victim:Name() .. " was killed by " .. attacker:Name() .. "." )
	end
end

hook.Add("GM:PlayerDeath", "muerte", suicidio( victim, attacker )

end
)

I would like to know what is wrong on this code :) The error is :

[ERROR] lua/autorun/cosas.lua:15: '=' expected near 'function'

[Skere_]

I usually connect the function name with its arguments, but I'm not sure if that does anything

[lua]function suicidio(victim, attacker)[/lua]

[jonitah112]

Now the code is

function suicidio(victim, attacker)
	if ( victim == attacker ) then
		PrintMessage( HUD_PRINTTALK, victim:Name() .. " committed suicide." )
	else
		PrintMessage( HUD_PRINTTALK, victim:Name() .. " was killed by " .. attacker:Name() .. "." )
	end
end

hook.Add("GM:PlayerDeath", "muerte", suicidio( victim, attacker )

end
)

and it still gives the same error :(

[Skere_]

What does the last ) & end close?

[jonitah112]

It ends hook.Add(

[Skere_]

You don't have to end a hook.Add with ''end''

[jonitah112]

Okay the problem was that end is not needed. The code now is :

function suicidio(victim,attacker)
	if ( victim == attacker ) then
		PrintMessage( HUD_PRINTTALK, victim:Name() .. " committed suicide." )
	else
		PrintMessage( HUD_PRINTTALK, victim:Name() .. " was killed by " .. attacker:Name() .. "." )
	end
end

hook.Add("GM:PlayerDeath", "muerte", suicidio( victim, attacker ) )

But the error now is [ERROR] lua/autorun/cosas.lua:4: attempt to index local 'victim' (a nil value)

[Skere_]

GM:PlayerDeath uses 3 arguments,

victim,inflictor,attacker

[boxvader2]

[QUOTE=jonitah112;49210805]Okay the problem was that end is not needed. The code now is :

function suicidio(victim,attacker)
	if ( victim == attacker ) then
		PrintMessage( HUD_PRINTTALK, victim:Name() .. " committed suicide." )
	else
		PrintMessage( HUD_PRINTTALK, victim:Name() .. " was killed by " .. attacker:Name() .. "." )
	end
end

hook.Add("GM:PlayerDeath", "muerte", suicidio( victim, attacker ) )

But the error now is [ERROR] lua/autorun/cosas.lua:4: attempt to index local 'victim' (a nil value)[/QUOTE]

Get rid of the GM: in hook.Add you only need to have PlayerDeath.
Also you don't need the brackets with the arguments in them when calling a function from hook.Add. The arguments are automatically passed.

This is the proper way.

hook.Add("PlayerDeath", "muerte", suicidio )

[jonitah112]

[QUOTE=boxvader;49210860]Get rid of the GM: in hook.Add you only need to have PlayerDeath.
Also you don't need the brackets with the arguments in them when calling a function from hook.Add. The arguments are automatically passed.

This is the proper way.

hook.Add("PlayerDeath", "muerte", suicidio )

[/QUOTE]

Great man! Thank you :D

This is my very first code :) i'm glad it finally works! :D

[boxvader2]

No problem glad you finally got it to work. I would suggest that you mark this thread as solved now.

[jonitah112]

Where do i mark it as solved? :o

[MysteryPancake]

[QUOTE=jonitah112;49211045]Where do i mark it as solved? :o[/QUOTE]

Top of the page, left hand side I think