Random Lua error on my server.

[0xymoron]

SO.
I was away from my server for 1 day, everything went to shit.
I did not add any new content besides Cake Anti-Cheat which had absolutely no problems.

Out of nowhere today we're getting this error constantly and it makes absolutely no sense.

Again, nothing new was added.

[ERROR] lua/includes/modules/concommand.lua:51: bad argument #1 to 'lower' (string expected, got nil)
  1. lower - [C]:-1
   2. Run - lua/includes/modules/concommand.lua:51
    3. unknown - addons/ulib/lua/ulib/shared/commands.lua:1310
     4. unknown - lua/includes/modules/concommand.lua:54

Any help would be appreciated.

[editline]28th July 2015[/editline]

Okay, I've just made a detour of concommand.Run to return nothing if the command is empty or nil.
I will post results to see if this fixes it.

[c👌de_g🎷]

Why would you do that? Why not just fix your code?

[0xymoron]

Look at the error.

I have no fucking clue WHERE the problem is.

I didn't add anything (that I know of) that includes a concommand.Run function, all I've added recently was cake anti-cheat and i'm not about to spend 8 hours trying to find the error in there.

From the error, all I see is that it's coming from ULib, and that's not accurate at all.

[editline]28th July 2015[/editline]

NOPE THAT DIDN'T FIX IT.

FUCK.

[editline]28th July 2015[/editline]

Trying one more thing, after this I have absolutely no idea what to do.

[c👌de_g🎷]

[QUOTE=0xymoron;48317321]Look at the error.

I have no fucking clue WHERE the problem is.

I didn't add anything (that I know of) that includes a concommand.Run function, all I've added recently was cake anti-cheat and i'm not about to spend 8 hours trying to find the error in there.

From the error, all I see is that it's coming from ULib, and that's not accurate at all.

[editline]28th July 2015[/editline]

NOPE THAT DIDN'T FIX IT.

FUCK.

[editline]28th July 2015[/editline]

Trying one more thing, after this I have absolutely no idea what to do.[/QUOTE]

Check the stack trace... the error is in ULib.

[0xymoron]

Yeah, nothing is fixing it. I consider myself screwed at this point.

[editline]28th July 2015[/editline]

Yes, I never modified ULib, I found the line of code but there's no reason it should be broken.
There is no reason this should be happening when I HAVENT TOUCHED ANYTHING.
How am I supposed to fix something that has no real error?

[c👌de_g🎷]

[QUOTE=0xymoron;48317389]Yeah, nothing is fixing it. I consider myself screwed at this point.

[editline]28th July 2015[/editline]

Yes, I never modified ULib, I found the line of code but there's no reason it should be broken.
There is no reason this should be happening when I HAVENT TOUCHED ANYTHING.
How am I supposed to fix something that has no real error?[/QUOTE]

That IS a real error. Can you post the line of ULib here?

[0xymoron]

if SERVER then
	sayCommandCallback = function( ply, sayCommand, argv )
		if not sayCmds[ sayCommand ] then
			return error( "Say command \"" .. sayCommand .. "\" is not defined!" )
		end

		sayCmds[ sayCommand ].__fn( ply, sayCmds[ sayCommand ].__cmd, argv )
	end

	local function hookRoute( ply, command, argv )
		concommand.Run( ply, table.remove( argv, 1 ), argv ) -- I assume it's here
	end -- Line 1310
	concommand.Add( "_u", hookRoute )
end

Here's the patch script which didn't work, it just happened again after being online for 40 minutes.

local patch = {}

patch.Detours = {}

function patch.Detour( nick, old, new )
	patch.Detours[old] = new
	MsgC( Color( 255, 0, 0 ), "[TSP] " )
	MsgC( Color( 255, 255, 0 ), "Detouring function " )
	MsgC( Color( 0, 255, 255 ), "'" .. nick .. "'\n" )
end

patch.Detour( "concommand.Run", concommand.Run, function( ply, command, arguments, args )
	if command == "" or command == " " or command == nil then
		 MsgC( Color( 255, 0, 0 ), "Found empty command '" .. command .. "'\n" )
		chat.AddText(
		Color( 255, 0, 0 ), "[TSP] ",
		Color( 255, 255, 0 ), "INVALID CONCOMMAND DETECTED! CONTACT TYLER ",
		Color( 0, 255, 0 ), "[" .. command .. "]" )
		return
	else
		return patch.Detours[concommand.Run]( ply, command, arguments, args )
	end
end )

patch.Detour( "string.lower", string.lower, function( str )
	if str == "" or str == " " or str == nil then
		MsgC( Color( 255, 0, 0 ), "Found empty string '" .. str .. "'\n" )
		chat.AddText(
		Color( 255, 0, 0 ), "[TSP] ",
		Color( 255, 255, 0 ), "INVALID CONCOMMAND DETECTED! CONTACT TYLER ",
		Color( 0, 255, 0 ), "[" .. command .. "]" )
		return
	else
		return patch.Detours[string.lower]( str )
	end
end )

[c👌de_g🎷]

table.remove doesn't return anything: that's your problem.

[AlvyP]

why would an empty console command be the cause of your problem? that doesn't make sense to me logically.
also, it's kind of rude that you would chargeback ley to buy cigarettes when you claim your server rakes in over $1000 a month, tyler wearing.
you failed to install the module, you think that running multiple ACs is inefficient, you don't like the logging because it's not in one file, it has no menu, these are your reasons? it's a pretty much autopilot anti-cheat, you can't have your cake and eat it too.

[c👌de_g🎷]

[QUOTE=Reyjr43;48317881]why would an empty console command be the cause of your problem? that doesn't make sense to me logically.[/QUOTE]

Helped him over Steam. Dumb ULX hook override was the issue.

[0xymoron]

[QUOTE=Reyjr43;48317881]why would an empty console command be the cause of your problem? that doesn't make sense to me logically.
also, it's kind of rude that you would chargeback ley to buy cigarettes when you claim your server rakes in over $1000 a month, tyler wearing.
you failed to install the module, you think that running multiple ACs is inefficient, you don't like the logging because it's not in one file, it has no menu, these are your reasons? it's a pretty much autopilot anti-cheat, you can't have your cake and eat it too.[/QUOTE]

Totally irrelevant, stop fucking flaming.
Also none of your business, go away.

[AlvyP]

[QUOTE=0xymoron;48317918]Totally irrelevant, stop fucking flaming.
Also none of your business, go away.[/QUOTE]

flaming? i'm point out the cold, hard truth, just because you don't like something doesn't mean you can just take your money back to buy cigarettes when you've paid for an addon, regardless of what claims you make.
to think you haven't grown a bit in 5 years absolutely baffles me.

[0xymoron]

[QUOTE=Reyjr43;48317931]flaming? i'm point out the cold, hard truth, just because you don't like something doesn't mean you can just take your money back to buy cigarettes when you've paid for an addon, regardless of what claims you make.
to think you haven't grown a bit in 5 years absolutely baffles me.[/QUOTE]

Looooooooool. *Pretends to know me*
Yeah have fun with that mate.

[0xymoron]

According to code_gs there is absolutely nothing we can do.
If anyone has any ideas it'd really help.

I submitted a bug report to ULX, I doubt anything will be done besides some kid telling me it's my addons
[url]https://github.com/Nayruden/Ulysses/issues/489[/url]

[AlvyP]

[QUOTE=0xymoron;48319619]According to code_gs there is absolutely nothing we can do.
If anyone has any ideas it'd really help.

I submitted a bug report to ULX, I doubt anything will be done besides some kid telling me it's my addons
[url]https://github.com/Nayruden/Ulysses/issues/489[/url][/QUOTE]

i can happily tell you that code_gs is wrong, as unusual as it is for code_gs to be wrong, take a look at the function that the error originates from and see where else it's called in ULX, all will become clear.

[YourStalker]

Both ULX and ULIB both don't have a files at /lua/includes/modules, they don't even have the includes folder at /lua/. You're either running an ancient version of ULX or using some custom code. If updating ULX from the their GitHub doesn't work then temporarily remove one addon at a time till you find the culprit.

[AlvyP]

[QUOTE=YourStalker;48322440]Both ULX and ULIB both don't have a files at /lua/includes/modules, they don't even have the includes folder at /lua/. You're either running an ancient version of ULX or using some custom code. If updating ULX from the their GitHub doesn't work then temporarily remove one addon at a time till you find the culprit.[/QUOTE]

Won't help because even the one on GitHub has this problem, it's really fucking simple to fix, the error legitimately tells you what the problem is, the thing is I'm not offering any help to Tyler because he chargebacked Ley and then defaulted out to asking for help when he ran into a problem.

[c👌de_g🎷]

[QUOTE=Reyjr43;48320351]i can happily tell you that code_gs is wrong, as unusual as it is for code_gs to be wrong, take a look at the function that the error originates from and see where else it's called in ULX, all will become clear.[/QUOTE]

That's because I didn't say that. I said an addon he had was conflicting with ULX's concommand override, which created an error from different calling methods

[AlvyP]

[QUOTE=code_gs;48334014]That's because I didn't say that. I said an addon he had was conflicting with ULX's concommand override, which created an error from different calling methods[/QUOTE]

Well then that would explain a lot, it sounded unusual that you would say that there was "absolutely nothing that could be done" considering how much unusual shit that occurred somewhere in the engine that has been fixed in GLua alone.

[c👌de_g🎷]

[QUOTE=Reyjr43;48335368]Well then that would explain a lot, it sounded unusual that you would say that there was "absolutely nothing that could be done" considering how much unusual shit that occurred somewhere in the engine that has been fixed in GLua alone.[/QUOTE]

ULX devs fixed the exploit with removing an empty arg: [url]https://github.com/Nayruden/Ulysses/commit/ddc0f93769c27f5ab0939c081a1bd95c5241a138[/url]

[AlvyP]

[QUOTE=code_gs;48337034]ULX devs fixed the exploit with removing an empty arg: [url]https://github.com/Nayruden/Ulysses/commit/ddc0f93769c27f5ab0939c081a1bd95c5241a138[/url][/QUOTE]

It will only fix ULib.redirect causing stack overflows if a client spams the "_u" command, there's still plenty of little exploits that will allow you to do the same thing effectively. ULX is a mess to be honest, there's all types of stupid stuff just like "_u"

[c👌de_g🎷]

[QUOTE=Reyjr43;48340530]It will only fix ULib.redirect causing stack overflows if a client spams the "_u" command, there's still plenty of little exploits that will allow you to do the same thing effectively. ULX is a mess to be honest, there's all types of stupid stuff just like "_u"[/QUOTE]

Well yes, but it stops calling any ULX ConCommand in a Think or Tick hook from breaking the whole server, which is a pretty nice fix.