Let's Code Some Effect-Based Weapons (that don't suck)

[Adrammelech09]

Alright, so I really want to know if anyone can help me with some effects. These include but are not limited to, muzzle flashes, tracers and hit effects. I think I know how to do hit decals.

under the bullet callback function:

util.Decal( "FadingScorch", tr.HitPos + tr.HitNormal * 2, tr.HitPos - tr.HitNormal * 2 );

I have an example of a muzzle flash taken from a weapon that works; under the primary attack function:

local effect = EffectData();
		effect:SetOrigin( self.Owner:GetShootPos() );
		effect:SetEntity( self.Weapon );
		effect:SetAttachment( 1 );
	util.Effect( "NomadMuzzle", effect ); -- it's from the pulse weapons, which are nice.

and finally, I learned how to code hit impacts by using this:

local HitImpact = function(attacker, tr, dmginfo)
    
local hit = EffectData()
hit:SetOrigin(tr.HitPos)
hit:SetNormal(tr.HitNormal)
hit:SetScale(20)
util.Effect( "AR2Impact", hit )

end

--and this--

Inside the SWEP.ShootBullet table...

bullet.Callback = HitImpact

in order to call the hit impact on each bullet.

So I just want to ask the community, am I doing it right?