Help with if statements

[gaz492]

im trying to make a weapon better in its a admin but it errors.

error

[ERROR] ...s/terrortown/entities/weapons/weapon_ttt_push/shared.lua:28: attempt to index global 'ply' (a nil value)
  1. unknown - ...s/terrortown/entities/weapons/weapon_ttt_push/shared.lua:28

code

if ply:IsSuperAdmin() then
	SWEP.primary.Delay = 0
	else
		SWEP.Primary.Delay = 3
end

[VladimirMurphy]

You're gonna have to include more of your Newton Launcher's code, because just from that I can't tell what all you've done to it, or where the error lies.

Edit: Why did I think that was the magneto stick?

[Drakehawke]

-snip-

[gaz492]

if SERVER then
   AddCSLuaFile("shared.lua")
end
   
SWEP.HoldType = "physgun"

if CLIENT then
   SWEP.PrintName = "newton_name"
   SWEP.Slot = 7

   SWEP.EquipMenuData = {
      type = "item_weapon",
      desc = "newton_desc"
   };

   SWEP.Icon = "VGUI/ttt/icon_launch"

   SWEP.ViewModelFlip = false
   SWEP.ViewModelFOV = 54
end

SWEP.Base				= "weapon_tttbase"

SWEP.Primary.Ammo   = "none"
SWEP.Primary.ClipSize		= -1
SWEP.Primary.DefaultClip	= -1
SWEP.Primary.Automatic		= true
if ply:IsSuperAdmin() then
	SWEP.primary.Delay = 0
	else
		SWEP.Primary.Delay = 3
end
SWEP.Primary.Ammo  = "none"
SWEP.Primary.Cone  = 0.005
SWEP.Secondary.ClipSize		= -1
SWEP.Secondary.DefaultClip	= -1
SWEP.Secondary.Automatic	= false
SWEP.Secondary.Ammo  = "none"
SWEP.Secondary.Delay = 0.5

SWEP.AutoSpawnable = false
SWEP.NoSights = true

SWEP.Kind = WEAPON_EQUIP2
SWEP.CanBuy = {ROLE_TRAITOR}

SWEP.WeaponID = AMMO_PUSH

SWEP.Primary.Sound = Sound( "weapons/ar2/fire1.wav" )
SWEP.Primary.SoundLevel = 54

SWEP.ViewModel  = "models/weapons/v_superphyscannon.mdl"
SWEP.WorldModel = "models/weapons/w_physics.mdl"
AccessorFuncDT(SWEP, "charge", "Charge")

SWEP.IsCharging = false
SWEP.NextCharge = 0

local CHARGE_AMOUNT = 0.02
local CHARGE_DELAY = 0.025

local math = math

function SWEP:Initialize()
   if SERVER then
      self:SetSkin(1)
   end
   return self.BaseClass.Initialize(self)
end

function SWEP:SetupDataTables()
   self:DTVar("Float", 0, "charge")
end

function SWEP:PrimaryAttack()
   self.Weapon:SetNextPrimaryFire( CurTime() + self.Primary.Delay )
   self.Weapon:SetNextSecondaryFire( CurTime() + self.Primary.Delay )

   self:FirePulse(600, 300)
end

function SWEP:SecondaryAttack()
   if self.IsCharging then return end

   self.Weapon:SetNextPrimaryFire( CurTime() + self.Primary.Delay )
   self.Weapon:SetNextSecondaryFire( CurTime() + self.Primary.Delay )

   self.IsCharging = true
end

function SWEP:FirePulse(force_fwd, force_up)
   if not IsValid(self.Owner) then return end

   self.Owner:SetAnimation( PLAYER_ATTACK1 )

   sound.Play(self.Primary.Sound, self.Weapon:GetPos(), self.Primary.SoundLevel)

   self.Weapon:SendWeaponAnim(ACT_VM_IDLE)

   local cone = self.Primary.Cone or 0.1
   local num = 6

   local bullet = {}
   bullet.Num    = num
   bullet.Src    = self.Owner:GetShootPos()
   bullet.Dir    = self.Owner:GetAimVector()
   bullet.Spread = Vector( cone, cone, 0 )
   bullet.Tracer = 1
   bullet.Force  = force_fwd / 10
   bullet.Damage = 1
   bullet.TracerName = "AirboatGunHeavyTracer"

   local owner = self.Owner
   local fwd = force_fwd / num
   local up = force_up / num
   bullet.Callback = function(att, tr, dmginfo)
                        local ply = tr.Entity
                        if SERVER and IsValid(ply) and ply:IsPlayer() and (not ply:IsFrozen()) then
                           local pushvel = tr.Normal * fwd

                           pushvel.z = math.max(pushvel.z, up)

                           ply:SetGroundEntity(nil)
                           ply:SetLocalVelocity(ply:GetVelocity() + pushvel)

                           ply.was_pushed = {att=owner, t=CurTime()}

                        end
                     end

   self.Owner:FireBullets( bullet )

end

local CHARGE_FORCE_FWD_MIN = 300
local CHARGE_FORCE_FWD_MAX = 700
local CHARGE_FORCE_UP_MIN = 100
local CHARGE_FORCE_UP_MAX = 350
function SWEP:ChargedAttack()
   local charge = math.Clamp(self:GetCharge(), 0, 1)
   
   self.IsCharging = false
   self:SetCharge(0)

   if charge <= 0 then return end

   local max = CHARGE_FORCE_FWD_MAX
   local diff = max - CHARGE_FORCE_FWD_MIN

   local force_fwd = ((charge * diff) - diff) + max

   max = CHARGE_FORCE_UP_MAX
   diff = max - CHARGE_FORCE_UP_MIN

   local force_up = ((charge * diff) - diff) + max

   self.Weapon:SetNextPrimaryFire( CurTime() + self.Primary.Delay )
   self.Weapon:SetNextSecondaryFire( CurTime() + self.Primary.Delay )

   self:FirePulse(force_fwd, force_up)
end

function SWEP:PreDrop(death_drop)
   -- allow dropping for now, see if it helps against heisenbug on owner death
--   if death_drop then
   self.IsCharging = false
   self:SetCharge(0)
--   elseif self.IsCharging then
--      self:ChargedAttack()
--   end
end

function SWEP:OnRemove()
   self.IsCharging = false
   self:SetCharge(0)
end

function SWEP:Deploy()
   self.IsCharging = false
   self:SetCharge(0)
   return true
end

function SWEP:Holster()
   return not self.IsCharging
end

function SWEP:Think()
   if self.IsCharging and IsValid(self.Owner) and self.Owner:IsTerror() then
      -- on client this is prediction
      if not self.Owner:KeyDown(IN_ATTACK2) then
         self:ChargedAttack()
         return true
      end

      
      if SERVER and self:GetCharge() < 1 and self.NextCharge < CurTime() then
         self:SetCharge(math.min(1, self:GetCharge() + CHARGE_AMOUNT))

         self.NextCharge = CurTime() + CHARGE_DELAY
      end
   end
end

if CLIENT then
   local surface = surface
   function SWEP:DrawHUD()
      local x = ScrW() / 2.0
      local y = ScrH() / 2.0

      local nxt = self.Weapon:GetNextPrimaryFire()
      local charge = self.dt.charge

      if LocalPlayer():IsTraitor() then
         surface.SetDrawColor(255, 0, 0, 255)
      else
         surface.SetDrawColor(0, 255, 0, 255)
      end

      if nxt < CurTime() or CurTime() % 0.5 < 0.2 or charge > 0 then
         local length = 10
         local gap = 5

         surface.DrawLine( x - length, y, x - gap, y )
         surface.DrawLine( x + length, y, x + gap, y )
         surface.DrawLine( x, y - length, x, y - gap )
         surface.DrawLine( x, y + length, x, y + gap )
      end

      if nxt > CurTime() and charge == 0 then
         local w = 40

         w = (w * ( math.max(0, nxt - CurTime()) /  self.Primary.Delay )) / 2

         local bx = x + 30
         surface.DrawLine(bx, y - w, bx, y + w)

         bx = x - 30
         surface.DrawLine(bx, y - w, bx, y + w) 
      end

      if charge > 0 then
         y = y + (y / 3)

         local w, h = 100, 20

         surface.DrawOutlinedRect(x - w/2, y - h, w, h)

         if LocalPlayer():IsTraitor() then
            surface.SetDrawColor(255, 0, 0, 155)
         else
            surface.SetDrawColor(0, 255, 0, 155)
         end

         surface.DrawRect(x - w/2, y - h, w * charge, h)

         surface.SetFont("TabLarge")
         surface.SetTextColor(255, 255, 255, 180)
         surface.SetTextPos( (x - w / 2) + 3, y - h - 15)
         surface.DrawText("FORCE")
      end
   end
end

this is the whole file

[VladimirMurphy]

As Drakehawke said before snipping, you're gonna want to put:

[lua]
if self.Owner:IsSuperAdmin() then
SWEP.Primary.Delay = 0
else
SWEP.Primary.Delay = 3
end
[/lua]

I'm not totally sure if that'll work though, or if it'd create unintended side effects such as non-Superadmins being able to use it without a delay if they pick it up off a dead Superadmin.
Friendly word of warning, though - giving admins/donators unfair advantages like this tends to piss off regular players, and I would personally advise against it.

[gaz492]

Its not saying

[ERROR] ...s/terrortown/entities/weapons/weapon_ttt_push/shared.lua:28: attempt to index global 'self' (a nil value)
  1. unknown - ...s/terrortown/entities/weapons/weapon_ttt_push/shared.lua:28

also how d you get the code box with line numbers?

[Drakehawke]

problem is it's outside a function, self isn't defined just in the file, you probably want to change ply to self.Owner, SENT to self and move it all to the start of PrimaryAttack

use [lua] tags

[gaz492]

[QUOTE=Drakehawke;38235386]problem is it's outside a function, self isn't defined just in the file, you probably want to change ply to self.Owner, SENT to self and move it all to the start of PrimaryAttack

use [lua] tags[/QUOTE]

Thanks that worked, just seeing what i can do as im trying to make a upgrade menu for vip's where they get small gun upgrades if they buy the upgrades.