( LUA ) Timer to Loop All, or just a timer per each.

[NewLifeRP]

The title is a little vague, don't hate. :PP Anyhow...

I was wondering which method is best?

local function RP_TimerFunc_PayDay()
	for i = 1, #player.GetAll() do
		if IsValid(player.GetAll()[i]) then
			local v = player.GetAll()[i]
			v:RP_PayDay()
		end
	end
end
timer.Create("RP_TimerHandle_PayDay",600,0,RP_TimerFunc_PayDay)

or this one... I'm also still kind of learning/trying to teaching myself a few things. Just need to know which one would be better for a
populated server. (32 players example.)

local function RP_PD_PlayerSpawn( ply )
    timer.Create("RP.PayDayTimer._"..ply:EntIndex(),600,0,function()
		if IsValid( ply ) then
			ply:RP_PayDay()
		end
    end)
end
hook.Add("PlayerSpawn","RP_PDT.PlayerSpawnHook",RP_PD_PlayerSpawn)

[B] All help is appreciated! [/B] :eng101: :eng101: :eng101:

[Tupac]

if you're thinking optimization-wise, and you want to make it as fast as possible, even if it's a small difference, this is how id go about the first method:

local function RP_TimerFunc_PayDay()
	local players = player.GetAll() -- cache it once instead of doing it each loop

	for i = 1, player.GetCount() do -- player.GetCount is faster than #player.GetAll() (according to the wiki)
		local pl = players[i]
		if not IsValid(pl) then continue end
		
		pl:RP_PayDay()
	end
end
timer.Create("RP_TimerHandle_PayDay",600,0,RP_TimerFunc_PayDay)

[posix_t9]

How much faster than player.GetCount() would #players be at that point, though

Legit question

[Sean Bean]

[QUOTE=IceGT_;52515213]How much faster than player.GetCount() would #players be at that point, though

Legit question[/QUOTE]

Not very and it's still faster to use [img]http://wiki.garrysmod.com/favicon.ico[/img] [url=http://wiki.garrysmod.com/page/Global/ipairs]ipairs[/url].

[c👌de_g🎷]

player.GetCount is slower than counting the player.GetAll table for looping. player.GetCount is only faster when you need the count and not the actual table. Ex.

local tPlayers = player.GetAll()

-- DO:
for i = 1, #tPlayers do
end

-- DON'T:
for i = 1, player.GetCount() do
end

[editline]28th July 2017[/editline]

[QUOTE=Sean Bean;52515353]Not very and it's still faster to use [img]http://wiki.garrysmod.com/favicon.ico[/img] [url=http://wiki.garrysmod.com/page/Global/ipairs]ipairs[/url].[/QUOTE]

No, numeric-for loop will always be faster than an iterator.

[Rubat]

What makes you think player.GetAll() is faster than player.GetCount in any scenario?

[c👌de_g🎷]

[QUOTE=Robotboy655;52515376]What makes you think player.GetAll() is faster than player.GetCount in any scenario?[/QUOTE]

player.GetAll isn't faster, table counting is faster than player.GetCount. If you're calling player.GetAll anyway, then you should just count the table.

[Tupac]

[QUOTE=code_gs;52515394]player.GetAll isn't faster, table counting is faster than player.GetCount. If you're calling player.GetAll anyway, then you should just count the table.[/QUOTE]

ye ur right, didn't think it through ;)

[NewLifeRP]

[QUOTE=code_gs;52515358]player.GetCount is slower than counting the player.GetAll table for looping. player.GetCount is only faster when you need the count and not the actual table. Ex.

local tPlayers = player.GetAll()

-- DO:
for i = 1, #tPlayers do
end

-- DON'T:
for i = 1, player.GetCount() do
end

[editline]28th July 2017[/editline]

No, numeric-for loop will always be faster than an iterator.[/QUOTE]

I was curious on that player.GetCount() and what the real difference was. I just seen that it was supposed to "faster" than player.GetAll() but I didn't know exactly what for, or how/why the difference is
is.

Anyway, thanks for the help! @Everyone

[aStonedPenguin]

With lua jit it's perfectly acceptable to just use ipairs. The speed difference between a for loop and ipairs is often non existent or negligible. It's more manageable too imo.