C# if statements

[sol_yurick]

Can if statements be on one line and is it common practice/acceptable, e.g:

if (!foo) {bar++;}

Are the curly brackets even needed then? Sorry if this seems like a stupid question, just my new tutor for uni is really pissy about standards.

[efeX]

There isn't really a standard for that AFAIK.. It's more coding style and preference. So you can't really go wrong.

[t0rento]

I'm not sure if there is a recommended standard similar to how Java's coding standard works, however valid code is:

if (!foo)
    bar++;

or

if (!foo)
    {
    bar++;
    }

(Regardless of indention style)

I prefer the second because the first can sometimes lead to subtle mistakes like:

if (!foo)
    bar++;
    foobar++;

In answer to your question, yes statements can be on one line as you pointed out (with or without the curly braces) generally it depends on the specific project your working on.

It's less important to follow a single standard and more important to make sure that there is some sort of [b]consistent[/b] standard. Ask your teacher or chose what you prefer.

[Ortzinator]

Personally, if it's something short like that, I do, but not usually.

[ShaRose]

[QUOTE=Ortzinator;18826137]Personally, if it's something short like that, I do, but not usually.[/QUOTE]

Depends on whether or not it helps the code look more readable. If It's important and I want to draw attention to it I will use braces, but if it's some short thing I won't bother. I will usually keep the if statement and the result on different lines though, and tab appropriately.

[Pepin]

You could even do

if (!foo) bar++;

[Nisd]

or you can do

foo ? Console.Write("It is true") : Console.Write("It is false")

[jivemasta]

It really depends on the case. One line looks better when you are just going to do one thing. But if you are doing multiple lines or elseifs and such it's easier to tell what's going on if you split it between lines.

[ShaRose]

[QUOTE=Nisd;18915140]or you can do

foo ? Console.Write("It is true") : Console.Write("It is false")

[/QUOTE]

That's not really the best usage case for that. Usually I use it for assigning a variable, like

uint unsigned = (uint)(signed < 0 ? -signed : signed);

Or something like that.

[Nisd]

I quite often use it when I need to print something out for debugging. Like

Console.Writeline(p.IsRunning ? ("Process is running") : (Process is not running"))

[bord2tears]

I end up doing this often when doing getters and setters.

Such as:

public double measurement
{
     get { return getMeasurement(); }
     set { setMeasurement(value); }
}

[hakusaro]

Depends on the context. I avoid one line code if I need to have more than one statement.

if (a = 123)
{
Console.Writeline("123");
}
else
{
Console.Writeline("345");
}

[turby]

[QUOTE=bord2tears;18979804]I end up doing this often when doing getters and setters.

Such as:

public double measurement
{
     get { return getMeasurement(); }
     set { setMeasurement(value); }
}

[/QUOTE]

Er, what's wrong with:

public double measurement { get; set; }

[gparent]

There's some things you can't do with auto-properties. Maybe he's doing some validation in setMeasurement that would cause an infinite loop with the get.

Then again, that could be me not knowing how to use the properties correctly in certain situations.

[Ortzinator]

You still don't need the extra methods though.

[gparent]

Nah, just an extra private variable.