Quick C Question

[holon]

I'm very, very new to C but not to programming languages so I've managed to piece together some basic code. I'm going to assume that it's possible to compile something without warnings, does anybody know how to deal with

warning: implicit declaration of function `strcpy`
warning: incompatible implicit declaration of built-in function `strcpy`
warning: implicit declaration of function `strcat`
warning: incompatible implicit declaration of built-in function `strcat`

[B]main.c:[/B]

#include <stdio.h>
#include <stdlib.h>

#include "ace_main.h"

int main() {
     msg "Test Message!");
     return 0;
}

[B]ace_main.h[/B]:

void msg(const char* msg) {
     char str[128];

     strcpy(str, msg);
     strcat(str, "\n");

     printf(str);
}

I'm compiling on linux using [B]gcc[/B].

[Kamshak]

idk if this is the cause but
msg "Test Message!");
msg( "Test Message!");

[holon]

I'll try, thanks

[editline]10th June 2012[/editline]

That was just a typo I made when copying it over, since the machine I'm using to compile is Linux and separate to my current windows machine.

[Liquid Helium]

your missing:

#include <string.h>

also, it's probably better to just do

void msg(const char* msg) {
     printf("%s\n", msg);
}

[holon]

Thanks

[Jookia]

Also, use strncpy. Otherwise you'll get a buffer overflow and [b]fuck shit up[/b].

[SiPlus]

Never declare functions in headers, declare only their prototypes in headers if you want to share functions between code files, and write code of functions only in code files.

[drrs]

[quote]Never declare functions in headers, declare only their prototypes in headers if you want to share functions between code files, and write code of functions only in code files.[/quote]

this->goodAdvice, oh wait :suicide: