Facepunch for Android--Now with 100% less login issues and Tablet UI!
633 replies, posted
[QUOTE=geel9;35231284]Just fixed logging in.
It was due to Overv converting the byte[] returned from the MD5 hasher to a BigInt, which works for most hashes, but when the hash began with a 0, it ignored the 0.
Anyways, the fix is live on Dropbox, and will be live on the market whenever Google propagates.[/QUOTE]
um so you're using overv's code as part of this app?
is there any particular reason that he isn't even mentioned in the OP when you're using his code AND user interface?
Editing posts does not work on the latest version, also the ratings are not in the correct order.
-removed-
[highlight](User was permabanned for this post ("Bot" - Craptasket))[/highlight]
[QUOTE=Overv;35242678]Nice job blaming me for problems in your application after raping the UI and altering our agreement to give me less money. Nothing I wouldn't expect from you, though.[/QUOTE]
Nice job being the reason people couldn't login for a long time.
Nothing I wouldn't expect from you, though. I guess you just never got around to actually finishing that MD5 function, huh?
[QUOTE=Overv;35242678]Nice job blaming me for problems in your application after raping the UI and altering our agreement to give me less money. Nothing I wouldn't expect from you, though.[/QUOTE]
Care to elaborate on that agreement?
[QUOTE=geel9;35243439]Nice job being the reason people couldn't login for a long time.
Nothing I wouldn't expect from you, though. I guess you just never got around to actually finishing that MD5 function, huh?[/QUOTE]
Stop blaming him, it's your own fault that you decided to use his code without checking or modifying it.
[editline]edit[/editline]
And if you really didn't bother going over that code I wonder how much more was not written by you. For all we know you could have written three or so shitty functions built upon the already functional codebase, then you refuse (or decrease) the amount of profit for the original creator after begging so dearly for donations? You don't deserve my money. Perhaps I'll just donate directly to Overv..
[QUOTE=sam6420;35245643]I'm still waiting on an iphone version...[/QUOTE]
Cool, it's only been mentioned about a hundred times in this thread. i300 is suposed to be working on one but he might be busy working on something else, as this probably isn't very high priority. Perhaps if you are tired of waiting you should make your own?
You can make an app for the iphone with C# right?
[QUOTE=eternalflamez;35246312]You can make an app for the iphone with C# right?[/QUOTE]lol
[QUOTE=eternalflamez;35246312]You can make an app for the iphone with C# right?[/QUOTE]
lol
[QUOTE=douche beat;35245616]Stop blaming him, it's your own fault that you decided to use his code without checking or modifying it. [editline]edit[/editline] And if you really didn't bother going over that code I wonder how much more was not written by you. For all we know you could have written three or so shitty functions built upon the already functional codebase, then you refuse (or decrease) the amount of profit for the original creator after begging so dearly for donations? You don't deserve my money. Perhaps I'll just donate directly to Overv..[/QUOTE]
When I took over, Overv had most of the Java API written, the login page, and the main page. I then wrote everything else, and used his design style. After that, I switched to using Hexxeh's JSON API, so I had to rewrite the vast majority of the API code that Overv wrote.
Overv and I originally agreed upon 33% for him, but after I rewrote the API code, we agreed to lower that to 25%, as the only thing he had made that was still in the app were small snippets of code and the general design style.
[editline]22nd March 2012[/editline]
I should also note that I never "refused" Overv his money. Everything was agreed upon by both of us.
lol
[QUOTE=geel9;35246869]When I took over, Overv had most of the Java API written, the login page, and the main page. I then wrote everything else, and used his design style. After that, I switched to using Hexxeh's JSON API, so I had to rewrite the vast majority of the API code that Overv wrote.
Overv and I originally agreed upon 33% for him, but after I rewrote the API code, we agreed to lower that to 25%, as the only thing he had made that was still in the app were small snippets of code and the general design style.
[editline]22nd March 2012[/editline]
I should also note that I never "refused" Overv his money. Everything was agreed upon by both of us.[/QUOTE]
And what was different from the current API and the previous one? Would it just scrape pages directly and modify them or was it the old FP API compwhizii made? If the latter then it couldn't have taken THAT long to rewrite it, the format seems extremely similar. And parsing JSON isn't exactly open heart surgery.
[QUOTE=geel9;35246869]When I took over, Overv had most of the Java API written, the login page, and the main page. I then wrote everything else, and used his design style. After that, I switched to using Hexxeh's JSON API, so I had to rewrite the vast majority of the API code that Overv wrote.
Overv and I originally agreed upon 33% for him, but after I rewrote the API code, we agreed to lower that to 25%, as the only thing he had made that was still in the app were small snippets of code and the general design style.
[editline]22nd March 2012[/editline]
I should also note that I never "refused" Overv his money. Everything was agreed upon by both of us.[/QUOTE]
You forgot that I also argued that UI design was the most difficult part of the application, as evident by your own endeavours.
[QUOTE=geel9;35243439]Nice job being the reason people couldn't login for a long time.
Nothing I wouldn't expect from you, though. I guess you just never got around to actually finishing that MD5 function, huh?[/QUOTE]
Maybe instead of being an ass to the guy that gave the app a face, you be thankful - or just rewrite the entire thing from scratch, as that's what you seem to think you have done..
The UI plays an enormous factor of the final app, even if you rewrote the "API" for parsing the JSON you still used his design, if you hadn't the outcome probably wouldn't have been as good
[img]http://i.imgur.com/2FkJT.png[/img]
(An artistic representation)
Overv at least deserves some credit in your app (and OP for that matter)
[QUOTE=geel9;35243439]Nice job being the reason people couldn't login for a long time.
Nothing I wouldn't expect from you, though. I guess you just never got around to actually finishing that MD5 function, huh?[/QUOTE]
wow man what a sweet zinger! "nice job letting me take credit for your work and then having bugs in it that i didnt notice!!"
you're paying him 25% to [B]continue using code you said you weren't going to use[/B] and use his UI? the UI alone should earn him half of your donations
and so the last tiny sliver of respect i had for geel is gone
Bug: Keyboard won't autoclose
having a chat with geel has revealed some interesting stuff
with regards to the lack of credit to overv:
[img]http://i.imgur.com/kye8b.png[/img]
apparently geel just "forgot" to credit overv for the massive amount of work he did for FPAndroid, in both the OP of this thread [B]and the Android Market page[/B]
but then he changed his story and said overv was a cunt so he didnt bother to credit him for his work (i.e. hes mean so i will intentionally disregard crediting the author)
[img]http://i.imgur.com/kHAs7.png[/img]
[img]http://i.imgur.com/dRRVx.png[/img]
[img]http://i.imgur.com/S4Ww2.png[/img]
during the chat geel made it clear how important he is and how useless overv really was in the scope of the massive undertaking that is, FPAndroid
[img]http://i.imgur.com/zsO9A.png[/img]
then geel gave us a schooling on how copyright and content authoring works
[img]http://i.imgur.com/ByKHN.png[/img]
apparently all the work that Overv did on the FPAndroid user interface is nullified by the fact that Overv just "copied" the Facepunch forums style, therefore it isn't his work
don't worry though, geel still did a lot of work, including
[img]http://i.imgur.com/BIoqD.png[/img]
so geel developed all of the user interface apart from the login screen and the front page, but the front page is a template that extends to almost every part of the app apart from the thread view, so essentially what geel is saying is that he developed the "View Thread" page. good job geel, i'm sure that warrants 75% of the donations that you constantly beg for. but hey, no biggie, what about the actual code? you know, the meat of the application, what makes everything tick?
[img]http://i.imgur.com/91Axi.png[/img]
well jeez, very small snippets doesn't sound all that bad. lets compare the code for Geel's FPAndroid, and overv's FPAndroid
for instance, take a look at APISession.java for both projects:
[B]overv:[/B] [url]https://github.com/Overv/Facepunch-App/blob/master/src/nl/vertinode/facepunch/APISession.java[/url]
[B]geel:[/B] [url]https://github.com/geel9/FPAndroid/blob/master/src/com/geel9/facepunch/APISession.java[/url]
[B]overv:[/B]
[csharp]
public enum Rating
{
AGREE( "Agree" ), DISAGREE( "Disagree" ), FUNNY( "Funny" ), WINNER( "Winner" ), ZING( "Zing" ), INFORMATIVE( "Informative" ), FRIENDLY( "Friendly" ),
USEFUL( "Useful" ), OPTIMISTIC( "Optimistic" ), ARTISTIC( "Artistic" ), LATE( "Late" ), DUMB( "Dumb" ), PROGRAMMINGKING( "Programming King" ),
MAPPINGKING( "Mapping King" ), LUAKING( "Lua King" ), LUAHELPER( "Lua Helper" ), SMARKED( "Smarked" ), MOUSTACHE( "Moustache" );
String ratingName;
Rating( String name )
{
ratingName = name;
}
@Override
public String toString()
{
return ratingName;
}
public static Rating fromString( String htmlName )
{
for( Rating r : values() )
if( r.name().equalsIgnoreCase( htmlName ) )
return r;
return null;
}
}
[/csharp]
[B]overv:[/B]
[csharp]
public class FPUser
{
private FPUser() {}
private int id;
private String name;
public Rank rank = Rank.REGULAR;
private boolean online;
private int joinYear;
private String joinMonth;
private int postCount;
public int getId() { return id; }
public String getName() { return name; }
public Rank getRank() { return rank; }
public boolean isOnline() { return online; }
public int getJoinYear() { return joinYear; }
public String getJoinMonth() { return joinMonth; }
public int getPostCount() { return postCount; }
}
[/csharp]
now for Geel!
[B]geel:[/B]
[csharp]
public enum Rating
{
AGREE( "Agree", 1 ), DISAGREE( "Disagree", 2 ), FUNNY( "Funny", 3 ), WINNER( "Winner", 18 ), ZING( "Zing", 13 ), INFORMATIVE( "Informative", 4 ), FRIENDLY( "Friendly", 5 ),
USEFUL( "Useful", 6 ), OPTIMISTIC( "Optimistic", 7 ), ARTISTIC( "Artistic", 8 ), LATE( "Late", 9 ), DUMB( "Dumb", 12 ), PROGRAMMINGKING( "Programming King", 14 ),
MAPPINGKING( "Mapping King", 17 ), LUAKING( "Lua King", 16 ), LUAHELPER( "Lua Helper", 19 ), SMARKED( "Smarked", 15 ), MOUSTACHE( "Moustache", 21 );
String ratingName;
int ratingId;
Rating( String name, int id)
{
ratingName = name;
ratingId = id;
}
@Override
public String toString()
{
return ratingName;
}
public int ID(){
return ratingId;
}
public static Rating fromString( String htmlName )
{
for( Rating r : values() )
if( r.name().equalsIgnoreCase( htmlName ) )
return r;
return null;
}
}
[/csharp]
[B]geel:[/B]
[csharp]
public class FPUser
{
private FPUser() {}
private int id;
private String name;
private String name_html;
public String userTitle = "";
public Rank rank = Rank.REGULAR;
private boolean online;
private int joinYear;
private String joinMonth;
private int postCount;
public int getId() { return id; }
public String getName() { return name; }
public Rank getRank() { return rank; }
public String getStyledName() {
return name_html;
}
public boolean isOnline() { return online; }
public int getJoinYear() { return joinYear; }
public String getJoinMonth() { return joinMonth; }
public int getPostCount() { return postCount; }
}
[/csharp]
as you can see geel.. barely used.. snippet... hmph
go ahead and look for yourself, i'm sure you'll find that geel is completely justified in saying he only uses "small snippets" of overvs work!
besides, who cares if geel is using overv's UI and code? as long as he respects the wishes of the author and ceases to use overvs work when requested, whats the issu--
[img]http://i.imgur.com/C0a7d.png[/img]
[img]http://i.imgur.com/gZBPy.png[/img]
in the end, geel promised he would remove all traces of overv's code and UI, and rewrite FPAndroid altogether, on his own, like a big boy
[img]http://i.imgur.com/Og30V.png[/img]
let's hope he keeps his word on that.
until then, please stop donating to an arrogant 16 year old plagiarist who doesn't feel obligated to respect the wishes of someone whose work he heavily depends on until threatened with serious legal action.
[B]tl;dr[/B]
geel is bad, read the post
[QUOTE=Kopimi;35257704]pics, text and code. Snipped to avoid page stretch.
[B]tl;dr[/B]
geel is bad, read the post[/QUOTE]
The code you show there looks about the same, yes, but since those are the variables you can take from any profile, those are the variables you make.
Other code is quite basic aswell, at least the ones you show there, I'm not gonna spit through 2.4k lines of code total to compare the two.
The login is just a table with username password and a button. Also has the color scheme used on fp, but it looks like so many of the login pages I've built in my time.
The main page with the threads is just a list of the thread names? No originality, really.
[editline]23rd March 2012[/editline]
I agree on the fact that geel9 should have given credit anyway, though. If even he admits that, then he should have.
[QUOTE=eternalflamez;35257768]The code you show there looks about the same, yes, but since those are the variables you can take from any profile, those are the variables you make.
Other code is quite basic aswell, at least the ones you show there, I'm not gonna spit through 2.4k lines of code total to compare the two.
The login is just a table with username password and a button. Also has the color scheme used on fp, but it looks like so many of the login pages I've built in my time.
The main page with the threads is just a list of the thread names? No originality, really.
[editline]23rd March 2012[/editline]
I agree on the fact that geel9 should have given credit anyway, though. If even he admits that, then he should have.[/QUOTE]
[QUOTE=eternalflamez;35246312]You can make an app for the iphone with C# right?[/QUOTE]
sorry im gonna have to disregard your opinion on code-related issues
Throw all the boxes you have at me, if you have to. But please explain your point aswell.
[editline]23rd March 2012[/editline]
[QUOTE=Kopimi;35257774]sorry im gonna have to disregard your opinion on code-related issues[/QUOTE]
Oh I'm sorry for never having made an app for the iphone.
-Warning: Shit storm incoming-
[QUOTE=eternalflamez;35257768]The login is just a table with username password and a button. Also has the color scheme used on fp, but it looks like so many of the login pages I've built in my time.
The main page with the threads is just a list of the thread names? No originality, really.[/QUOTE]
It is definitely clear though, no matter how simple it may be, that geel9 couldn't have done it himself and I think he should come with his own work.
[QUOTE=Overv;35257827]It is definitely clear though, no matter how simple it may be, that geel9 couldn't have done it himself.[/QUOTE]
Ok, I submit. I looked to the code, and even on geel9's page, at least 50% is yours.
I drop my previous standings, you guys are right.
[editline]23rd March 2012[/editline]
Also, bug: When typing "ï" it shows up as ï on my main pc.
[QUOTE=eternalflamez;35257834]Ok, I submit. I looked to the code, and even on geel9's page, at least 50% is yours.
I drop my previous standings, you guys are right.
[editline]23rd March 2012[/editline]
Also, bug: When typing "ï" it shows up as ï on my main pc.[/QUOTE]
thats a bug with the api
[QUOTE=Pocoyo;35258063]thats a bug with the api[/QUOTE]
it's easily fixable by api consumers by treating the data as utf-8 no matter what hexxeh's server says
Personally I think letting geel9 use the code at all was a mistake, but then it was on GitHub, so you couldn't really stop him.
I think what should happen is that geel9 should forefit what he's earned so far in "donations", cease to accept "donations", properly credit Overv and then just carry on as before.
FWIW, back when I developed an iPhone app using FPAPIv1, I had an agreement with garry to split the apps revenue. Since the API is now run on servers owned by me, which in turn query Facepunch servers, revenue should be split between me, garry and the app developer.
However, since that's complex and probably not even worth bothering with, I just asked that app developers using my API made their applications free.
[QUOTE=Kopimi;35257704]Them chatlogs and everything[/QUOTE]
Is it really necessary to mock geel and call him thirteen?
Also the "contract is void and you dont have author permission" is just dumb of you, I'm sure he knows and if not Overv could tell him that.
I feel that if you would've left this entire discussion to geel and Overv it would be better than to interfere with retarded shit like "ok so you're going to continue usings overs work against his will?"
I'm not defending geel just saying that you're being an ass.
Facepunch for Android -- Now with 100% more arguments!
[QUOTE=sam6420;35264947]Ladies and gentlemen: high school drama.
Grow up, all of you.[/QUOTE]
uhh if someone was graduating high school and getting a scholarship based on someone else's work that he has been explicitly asked not to use, then yes i guess this would equate to high-school drama
Sorry, you need to Log In to post a reply to this thread.