Knockout Development v2 - It's time to start posting on Knockout!
298 replies, posted
...so, wait, Garry is legit committed to pulling the plug then, from recent conversations with the mods?
Yes. Its just time and how Garry wants handle it. He is going to take some time and care and he will reply himself on how he wants to take the next few steps.
Sandbox could have powered a new generation of Facepunch Forums. RIP.
I dunno seems like a strange choice for a forum host
i've been signed out of knockout and can't remember what auth method i used to sign up. is there a way to log out if i use the wrong one?
I was thinking the same thing. So much potential. After all, though, we already have two (or more?) continuations of the idea being advertised on KO; Pragma by Silverlan and Sandboxes by Pitr are the two I'm most attentive to. There's hope.
I did the same. Picked the wrong one and now I'm stuck on the user creation page with no way to back out of it.
enter some random username and log out, it's fine
I'm not entirely sure but I think it's somehow related to a popup setting. However I don't seem to be able to locate that setting in about:config, even when sorting by settings that have been set manually. (It's actually a setting that was set through Tab Mix Plus but since Mozilla completely broke nearly every single aspect of that addon when they adopted the shitty Web Extension standard, I can't exactly go and reset it through that.) When I click the login button on KO, it opens the Google auth page and then the auth/finish page on KO in the same tab as Knockout was originally opened. Looking at the Javascript event attached to the Google login button, it appears to be trying to open it in a new window altogether. (Which is something I hate because popup windows like that really love hiding the address bar and such which shouldn't even be allowed.) For reference, even unblocking popups through Firefox's config still opens it in the same tab.
on my firefox with ubo, umatrix, poperblocker and privacy badger, i am still able to log in (with all of them enabled).
i didn't modify any settings on firefox, though (at least none that i can remember)
Is this with the Google auth page loading into the same tab as Knockout was in?
And I just ran through the process again using Firefox's debugger to see what was running and the values of things.
https://i.imgur.com/zcp1r9y.png
The blue lines are breakpoints and every one of those breakpoints except the one on line 18 runs. window.opener is the auth/finish/ page and the user variable ends up being the data it should be according to what I previously copied over from Vivaldi. It appears that the parent.postMessage() or window.close() lines are the ones that are failing, though there's no errors given in the console.
I was going to suggest maybe just setting the localStorage setting here but interestingly it appears this page being on port 3000 doesn't have access tot he same localStorage as the rest of the site does.
no, it opens in a different page i think (i tested it a couple days ago with a fresh install of firefox)
are there any settings related to popups or something (that arent the defaults for firefox) that could be preventing you from getting a window.opener?
browser.link.open_newwindow.restriction
Finally found the setting. Oddly enough 3 is what I had it set to which doesn't appear to be valid but acted like a setting of 0.
http://kb.mozillazine.org/About:config_entries#Browser.
From that page:
0 (Default in Firefox 1.0.x and SeaMonkey): Force all new windows opened by JavaScript into tabs.
1: Let all windows opened by JavaScript open in new windows. (Default behavior in IE.)
2 (Default in Firefox 1.5 and above): Catch new windows opened by
JavaScript that do not have specific values set (how large the window
should be, whether it should have a status bar, etc.) This is useful
because some popups are legitimate — it really is useful to be able to
see both the popup and the original window at the same time. However,
most advertising popups also open in new windows with values set, so
beware.
Setting it to 1 lets it successfully login and I'd assume 2 would as well. If there's any way you could manage to work around this it'd be rather convenient but I'm not sure what exactly you could do with it since I don't really mess with opening popups in any of my own projects.
phew! glad you fixed it. i knew it was a browser setting, extension or something :v
i have no idea if it'd be possible for us to do it given all the apis we use would have to support the same thing, but we can definitely look into it eventually
I guess those warnings when you open about:config about the posiblity to break things aren't all just fluff, good to know
At the very least, you might consider adding a troubleshooting section to the login page or something and including that as one of the possibilities that could break it on Firefox. Though it's odd that this only started happening when you fixed login for other Firefox users. Was the previous method handling things differently somehow in that regard?
The biggest issue with about:config is there's a lot of useful settings in there but so much of it is completely undocumented. Mozillazine has documented quite a few of them but nowhere near the majority and it's rather out of date a lot of the time. A lot of the useful settings have been moved over to the actual settings page at least, though far from all and any experimental features or features they're slowly rolling out over time (such as their new webrender api) are typically only accessible through it.
yes, we were using google's (absolutely fucking awful, abandoned) javascript login flow before, which is why it required 3rd party cookie support
Good to see the issue is fixed, and thanks for the detailed report. This was driving the whole dev team crazy.
me and @Northern Lights have been working on Mod Panel 2.0, which is why yall arent seeing as many features lately
sneak peek
https://files.facepunch.com/forum/upload/326417/c32c566b-3829-4f3d-82b3-4c6f3d71f8d2/image.png
https://files.facepunch.com/forum/upload/326417/a857884d-72bd-4676-b250-c854d74afc11/image.png
https://files.facepunch.com/forum/upload/326417/e4a46d17-8252-40c9-903e-00046eac4f72/image.png
https://files.facepunch.com/forum/upload/326417/f27a22b2-2f4b-43a5-8059-d5aefeb113e7/image.png
gib, I need it
I'd like to suggest a feature but I'm not sure if everyone else would be on board with it. I remember back in Oldpunch there used to be small rating markings on every thread in a subforum that would show the highest amount of a rating that the original post received (be it Winner, Funny, etc). What do you guys think?
It's on the Trello, so may happen eventually!
Trello
no reason not to!
in fact, this is already on Trello!
Thank you for all the wonderful work you are doing on keeping this community alive!
Speaking of old features. On Oldpunch if you clicked on the number of posts in a thread from the subforum page it would bring up a window with the names of each person who posted in the thread and how many posts they've made in the thread. Just a neat thing to consider.
I miss the little icon you could press next to the thread title that showed all of the photos that had been posted in the thread.
Acc has been made.
Many thanks for the effort.
At least we have another place to settle instead of being left in void when the plugs are pulled
Sorry, you need to Log In to post a reply to this thread.