Next Update v6.0 - October 2016

[c👌de_g🎷]

Finally found the reason for the message (from UTIL_Remove):

	if ( PhysIsInCallback() )
	{
		// This assert means that someone is deleting an entity inside a callback.  That isn't supported so
		// this code will defer the deletion of that object until the end of the current physics simulation frame
		// Since this is hidden from the calling code it's preferred to call PhysCallbackRemove() directly from the caller
		// in case the deferred delete will have unwanted results (like continuing to receive callbacks).  That will make it 
		// obvious why the unwanted results are happening so the caller can handle them appropriately. (some callbacks can be masked 
		// or the calling entity can be flagged to filter them in most cases)
		Assert(0);
		PhysCallbackRemove(oldObj);
		return;
	}

The method in question is actually just a safer version of Remove that handles PhysicsCallback cases:

void PhysCallbackRemove(IServerNetworkable *pRemove)
{
	if ( PhysIsInCallback() )
	{
		g_Collisions.AddRemoveObject(pRemove);
	}
	else
	{
		UTIL_Remove(pRemove);
	}
}

Would be great if the Lua binding was updated to this.

For anyone who's curious on what Entity:Remove() does internally: [url]https://github.com/LestaD/SourceEngine2007/blob/master/se2007/game/server/util.cpp#L442[/url]

[HighVoltage]

[QUOTE=mcNuggets1;51982987]It is still possible to change things and update things for the good.
Just because it's old it doesn't mean it has to "die".

It is still a relevant engine and is used in quite alot of games.

It has a lot of positive aspects, aswell as negative.
Redoing specific aspects wouldn't hurt anyone.[/QUOTE]

I'm not saying it's a dying engine, I'm saying you can't just fix everything cause most of the major issues would require a complete overhaul of multiple systems: something that just isn't feasible

[Pugsworth]

[QUOTE=highvoltage;51983886]I'm not saying it's a dying engine, I'm saying you can't just fix everything cause most of the major issues would require a complete overhaul of multiple systems: something that just isn't feasible[/QUOTE]

Even valve had to do some tricky things to get this to work in later games.
In Portal 2, they put the player in a static environment for the intro and put the camera in the room that is moving around.

This is also what many game still do.

[The Commander]

Incase people are not seeing this because it's in the General thread,

[url]https://facepunch.com/forumdisplay.php?f=15[/url]

Something needs to be done about this already, aka start blacklisting the offenders main servers, not the redirects, they have had enough warnings.

[ARitz Cracker]

Accept my PR pls
[url]https://github.com/garrynewman/garrysmod/pull/1343[/url]

[Heavy Bob]

I'm a little late, got the invite from [URL="https://facepunch.com/showthread.php?t=1557275"]this thread.[/URL].

[IMG]http://i.imgur.com/SRpiuCp.png[/IMG]
*My server browser in Australia. Note the latency on superior and divinity*
[IMG]http://i.imgur.com/sJr0ueK.png[/IMG]
*What I'm actually being redirected to.*

Fake redirect servers are becoming a serious problem for my region as they are deceptively siphoning players (from my homeland Australia) and redirecting victims unknowingly to American or European servers that often have 200 to 300 ping.

This is an unfair practice because:
- Its deceiving players into joining higher ping servers
- Its unfair for servers within a region to compete with artificial player counts
- Its making the server browser increasingly harder to trust.

If unfixed this will eventually lead to more servers to run this practice inturn making it harder to join a server that actually has low ping.

I just want to be able to trust the server browser to assist me in finding local servers in my region and not fake server shells. Please fix ggod.

[Tenrys]

That is such a shit way of dealing with it.

[ARitz Cracker]

[QUOTE=Heavy Bob;51986506]:words:[/QUOTE]

dun wrry. just show your approvel of my [URL="https://github.com/garrynewman/garrysmod/pull/1343"]absolutly flawless patch[/URL]

[Toedeli]

This could get abused so heavily, please, blacklist them. Imagine some hackers linking people to servers which infect computers.
Besides, enough is enough. No watching anymore, let's show people what they are not allowed to do.

[ARitz Cracker]

my pr has 6 thumnbs up and 11 smiling emojis. Looks like some people are already happy to se this problem eraditcated once anf for all!!

[mcNuggets]

It is not really a solution.
Just anything against these redirect nonsense is appreciated.

[SFAriel]

Here come "SüperiörServers".

What's your next step, LegoGuy?

[ARitz Cracker]

[QUOTE=SFArial;51986595]Here come "SüperiörServers".

What's your next step, LegoGuy?[/QUOTE]

[url]http://qaz.wtf/u/convert.cgi?text=abcdefghijklmnopqrstuvwxyz[/url]

[Toedeli]

If some dude which has quite power over GMOD in general would tell them to stop doing this, they would. No one here wants to go against a developer or Moderator.
Another solution is to somehow block redirection (I am stupid af and don't Know how to explain it, keke)
Anyways, I think a bot would not really be the best solution. If they don't have their Map uploaded to the Workshop, we can't say "this is the incorrect map". Kinda complicated to explain, excuses.

[NeatNit]

This comes up literally every week. I'm not saying this to complain about it coming up, I'm saying it to complain about [b][i]why the fuck isn't it fixed yet[/i][/b] just like everybody else. With what has essentially been continuous outcry from [i]everyone[/i] on this subforum except Penguin (and whatever the name of that anime avatar was), there is no doubt that this should be a high priority.

Personally I prefer new features over cleaning up penguin's shit, but enough is enough. I know aritz's PR was made in jest but, honestly, this sounds like a fitting punishment for the kind of lying manipulative asshole that he has shown himself to be.

[MeepDarknessM]

[QUOTE=Toedeli;51986549]This could get abused so heavily, please, blacklist them. Imagine some hackers linking people to servers which infect computers.[/QUOTE]

what the fuck are you talking about you can literally just infect them through the first server instead of the redirect

[QUOTE=LegoGuy;51986551]my pr has 6 thumnbs up and 11 smiling emojis. Looks like some people are already happy to se this problem eraditcated once anf for all!![/QUOTE]

those aren't smiling emojis, they are laughing.

you guys are fucking complaining over literally nothing, they aren't hurting your players, they aren't hurting their players, they aren't hurting anyone; WHY ARE YOU COMPLAINING??? are you just mindlessly joining a bandwagon? is there an actual valid concern here??

[Pugsworth]

If redirection is done via the "connect" command then a quick fix is to blacklist that console command from being ran from lua. There's no actual reason why anyone would be running that command from lua anyways.
A C function that prompts for user input first would allow connection via "lobby" servers still possible.

[Revenge282]

[QUOTE=MeepDarknessM;51986680]what the fuck are you talking about you can literally just infect them through the first server instead of the redirect

those aren't smiling emojis, they are laughing.

you guys are fucking complaining over literally nothing, they aren't hurting your players, they aren't hurting their players, they aren't hurting anyone; WHY ARE YOU COMPLAINING??? are you just mindlessly joining a bandwagon? is there an actual valid concern here??[/QUOTE]

Because if you are lying/manipulating server info to attract players to your server, then that is what most people would consider bad. If you're lying to AU users under the pretense of "oh look at our low pings!", then they get to the server on US East or wherever with 300+ ping, then I don't see how you can claim that to be a "legitimate practice".

[Bings]

[QUOTE=MeepDarknessM;51986680]what the fuck are you talking about you can literally just infect them through the first server instead of the redirect

those aren't smiling emojis, they are laughing.

you guys are fucking complaining over literally nothing, they aren't hurting your players, they aren't hurting their players, they aren't hurting anyone; WHY ARE YOU COMPLAINING??? are you just mindlessly joining a bandwagon? is there an actual valid concern here??[/QUOTE]

That's not the point of why people are complaining. Most people don't give a damn which server it is, its the reasoning behind it what's wrong and simply unfair on everyone else.

What we are talking about here is literally a tool to give you [B]massive[/B] reach over the world which is[B] pretty much a guarantee of high player counts[/B]. Its not as if the tool is being used to promote small gamemodes at the bottom of the list though either - its being used by people who aren't satisfied with the same server browser [B]EVERYONE[/B] else has to use as there not getting enough players. Its shocking.

[ARitz Cracker]

[QUOTE=Bings;51986704]That's not the point of why people are complaining. Most people don't give a damn which server it is, its the reasoning behind it what's wrong and simply unfair on everyone else.

What we are talking about here is literally a tool to give you [B]massive[/B] reach over the world which is[B] pretty much a guarantee of high player counts[/B]. Its not as if the tool is being used to promote small gamemodes at the bottom of the list though either - its being used by people who aren't satisfied with the same server browser [B]EVERYONE[/B] else has to use as there not getting enough players. Its shocking.[/QUOTE]

You see, this is why instead of blocking the server outright, I simply move the server where it belongs.

[Toedeli]

[QUOTE=MeepDarknessM;51986680]what the fuck are you talking about you can literally just infect them through the first server instead of the redirect

those aren't smiling emojis, they are laughing.

you guys are fucking complaining over literally nothing, they aren't hurting your players, they aren't hurting their players, they aren't hurting anyone; WHY ARE YOU COMPLAINING??? are you just mindlessly joining a bandwagon? is there an actual valid concern here??[/QUOTE]

No. We are concerning a Ping Spoof here. A lot of players search servers by the ping, meaning which Server has the most players and best ping for their area. This Server actually DOES harm our playerbase, people will join Superiorservers in the thought of having a better ping and will ignore other servers. This will kill many communities.
Secondly, continuing the ping, let's imagine the following situation: You open a Shop, you sell quite cheap products. People like to visit your Shop. But the next day, a new Shop opens which advertises on the outside the very good prices, which are bloody cheap. When you go in it, the products cost five times more than advertised. But mostly people don't pay attention to that, they just wanna buy stuff. So they stay there, visit the store again because they think it's much cheaper.
I hope you Know hat I'm trying to say, my English is bullshit.

[NeatNit]

[QUOTE=vexx21322;51986682]If redirection is done via the "connect" command then a quick fix is to blacklist that console command from being ran from lua. There's no actual reason why anyone would be running that command from lua anyways.
A C function that prompts for user input first would allow connection via "lobby" servers still possible.[/QUOTE]
There's plenty of reasons to redirect a player during gameplay. One classic example is the old GMod Tower, which redirected you to a gamemode server when your turn arrived. Another example would be using position-activated redirects to simulate a large game world via several normal-sized maps hosted on different servers.

Whether there should be a (potentially ugly) pop-up asking you to confirm, though, is a different matter.

[MeepDarknessM]

[QUOTE=Revenge282;51986702]Because if you are lying/manipulating server info to attract players to your server, then that is what most people would consider bad. If you're lying to AU users under the pretense of "oh look at our low pings!", then they get to the server on US East or wherever with 300+ ping, then I don't see how you can claim that to be a "legitimate practice".[/QUOTE]

They aren't lying about the players on the server they are joining.

The ping issue is a non issue.

They have little to no downloaded content on their server so once someone joins their server they will judge if they like the server enough to deal with ping or not then leave.

When did i say anything about legitamite practice?

[QUOTE=Bings;51986704]That's not the point of why people are complaining. Most people don't give a damn which server it is, its the reasoning behind it what's wrong and simply unfair on everyone else.

What we are talking about here is literally a tool to give you [B]massive[/B] reach over the world which is[B] pretty much a guarantee of high player counts[/B]. Its not as if the tool is being used to promote small gamemodes at the bottom of the list though either - its being used by people who aren't satisfied with the same server browser [B]EVERYONE[/B] else has to use as there not getting enough players. Its shocking.[/QUOTE]

This is not a valid argument on how it hurts the player base or any specific people.

They are not *stealing* the players from other servers. Players that want to play on the server will be on there. They are spreading the reach of their servers. People who join will notice the ping and if they don't like it they will leave, and not ever join back.

[Toedeli]

[QUOTE=MeepDarknessM;51986737]They aren't lying about the players on the server they are joining.

The ping issue is a non issue.

They have little to no downloaded content on their server so once someone joins their server they will judge if they like the server enough to deal with ping or not then leave.

When did i say anything about legitamite practice?

This is not a valid argument on how it hurts the player base or any specific people.

They are not *stealing* the players from other servers. Players that want to play on the server will be on there. They are spreading the reach of their servers. People who join will notice the ping and if they don't like it they will leave, and not ever join back.[/QUOTE]

Bloody hell read my comment.
It will get more people to JOIN and STAY on Superiorservers. Why are you even trying to argue? Do you really think we just say "oh lol, someone who tries to defend a Server which tricks players is trying to argue against a dozen of people, let's believe him".
Mate, again: The Server itself is good, but the lying about the ping prevents new players on other servers.

[MeepDarknessM]

[QUOTE=Toedeli;51986750]Bloody hell read my comment.
It will get more people to JOIN and STAY on Superiorservers. Why are you even trying to argue? Do you really think we just say "oh lol, someone who tries to defend a Server which tricks players is trying to argue against a dozen of people, let's believe him".
Mate, again: The Server itself is good, but the lying about the ping prevents new players on other servers.[/QUOTE]

what the fuck do you even read what i said?

it's [b]not a problem[/b]
if people want to play on their server they will, if they don't they won't
making an argument about redirect servers because they are stealing the players or are getting more players than you is fucking retarded. they are getting more people to stay because people genuinely like the server, not because they tricked them with ping in the server browser (which BY THE WAY they can see real ping in game)

[Heavy Bob]

[QUOTE=Revenge282;51986702]...If you're lying to AU users under the pretense of "oh look at our low pings!", then they get to the server on US East or wherever with 300+ ping, then I don't see how you can claim that to be a "legitimate practice".[/QUOTE]

Here is another snap from Australia. (1490020192) 2:30am Monday.
Again filtering Latency at < 150
[IMG]http://i.imgur.com/XzAXSGQ.png[/IMG]
Oh cool 97 players with 12 ping, WICKED!
[IMG]http://i.imgur.com/7LgGn9T.png[/IMG]
Nope.avi, top two results are just shell redirect servers to America.

No reasonable argument exists to trick people into playing higher ping servers.

[The Commander]

But they are at the top, they must be the best Australian server to play on.
Oh wait, I am being lied to and redirected to America but that's all fine and dandy according to Meep and isn't an issue at all.

[Toedeli]

[QUOTE=MeepDarknessM;51986758]what the fuck do you even read what i said?

it's [b]not a problem[/b]
if people want to play on their server they will, if they don't they won't
making an argument about redirect servers because they are stealing the players or are getting more players than you is fucking retarded. they are getting more people to stay because people genuinely like the server, not because they tricked them with ping in the server browser (which BY THE WAY they can see real ping in game)[/QUOTE]

You are really stubborn, right?
I wanna repeat myself, it is not the Server. It is the fact that it is faking Ping. You may never had a bloody Server because Mom's Visa changed the PIN Code, but it's really annoying for everyone who own a Server. Everyone wants players, right? But These methods are unfair.
Another example: Mustard Gas has been forboden after World War I due to it beeing to extreme to soldéiers. Still, everyone wants to win, right? Everyone wants to win the war, everyone could use it at all Moment. Imagine someone would use it. How would you feel? Everyone wants to win the war, but one is unfair and wants to get a better chance at winning.
Think first, then type.

[MeepDarknessM]

[QUOTE=The Commander;51986772]But they are at the top, they must be the best Australian server to play on.
Oh wait, I am being lied to and redirected to America but that's all fine and dandy according to Meep.[/QUOTE]

they are at the top, people are playing on it. they aren't lying about it being in the au. the ping is a non-issue as I said before. you guys are literally complaining about superiorservers because of their success.

[ARitz Cracker]

[QUOTE=MeepDarknessM;51986777]they are at the top, people are playing on it. [B]they aren't lying about it being in the au.[/B] the ping is a non-issue as I said before. you guys are literally complaining about superiorservers because of their success.[/QUOTE]

:speechless: