[QUOTE=raubana;52543727]Yay! Can I get facepunch gold now pl0x?[/QUOTE]
that'll be $1215 at the first window please
Well done everyone, was really entertaining watching the stream. Hopefully these gamemodes actually get popular, they were all good.
For all the people who aren't on our Discord server, here's the final rankings.
[T]https://cdn.discordapp.com/attachments/282446411012767746/343562417264918529/unknown.png[/T]
[QUOTE=Tupac;52544237]that'll be $1215 at the first window please[/QUOTE]
:scream: I'd like to speak with your manager!
nice coding
[img]http://i.imgur.com/l2c8u70.png[/img]
[img]http://i.imgur.com/NZCDEBO.png[/img]
[img]http://i.imgur.com/cCbA5W5.png[/img]
[img]http://i.imgur.com/EaKgZEL.png[/img]
[QUOTE=TrixterTheTux;52547145]Maybe look at the actual results? Half of them are custom hooks, and maybe someone actually added hooks for his gamemode so others can edit it?[/QUOTE]
Only hookAdd are checked, not hook.RunOnce
100% gmod hooks -> [DATA REQUIRED]
71.43% gmod hooks -> AttackOfTheMimics
68.92% gmod hooks, 28.38% of gamemode-specific hooks (useless since hooks are meant for external plugins), 2.7% of hooks used in TTT (Round hooks) -> The Floor Is Lava
100% gmod hooks -> gfodder
[QUOTE=pierre0158;52547118]nice coding
[img]http://i.imgur.com/l2c8u70.png[/img]
[img]http://i.imgur.com/NZCDEBO.png[/img]
[img]http://i.imgur.com/cCbA5W5.png[/img]
[img]http://i.imgur.com/EaKgZEL.png[/img][/QUOTE]
Maybe look at the actual results? Half of them are custom hooks, and maybe someone actually added hooks for his gamemode so others can edit it?
Why does it matter how good/optimized the code is for a gamemode that was made for a competition? you don't know how long they spent/had time to make it. (I'm taking into factor their personal schedules)
[QUOTE=Handsome Matt;52547180]? why do you feel that you need to attack the winners that badly that you'll try and grasp at anything... and then what you grasp at is complete nonsense anyway? what's the thought process that goes behind that other then just wanting to be a dick?
[editline]7th August 2017[/editline]
The code for these gamemode is mostly good anyway, the guy is pulling shit from his ass. Jealousy perhaps?[/QUOTE]
Reminder that Pierre/lapin is the same person who banned people from scriptenforcer for "Muslim"
[QUOTE=meharryp;52547218]Reminder that Pierre/lapin is the same person who banned people from scriptenforcer for "Muslim"[/QUOTE]
lies
What's the actual code smell here?
As someone who doesn't know what the complaint is, it seems like just a complaint about using the hook library.
[QUOTE=BadgerCode;52547332]What's the actual code smell here?
As someone who doesn't know what the complaint is, it seems like just a complaint about using the hook library.[/QUOTE]
When making a gamemode you're not supposed to use any hook, unless you want to make it work with with an addon.
On the gmod wiki, when looking for the hook, it shows you two example.
One with
[lua]GM:Think()[/lua]
And one other with
[lua]hook.Add("Think", "_whatyouwant_", function)[/lua]
The first one is supposed to be used when making gamemodes, and the second one in addons, because you can't simple overwrite the gamemode GM:Think function.
You can use hook.Run/hook.Call to allow people to code addons around your code, i really doubt there is a real reason to use hook.Add inside a gamemode code.
Don't tell me it's easier to use hook, just do :
[lua]
function GM:UrFunction()
urFunc1()
urFunc2()
urFunc3()
urFunc4()
end
[/lua]
Thanks for the explanation. That's quite helpful.
In my gamemode, I have an entity which calls one of my custom gamemode hooks.
[B]Entity[/B]:
[lua]
function ENT:StartTouch(entity)
if(!entity:IsPlayer()) then return end
hook.Run("PlayerTouchedTile", entity, self)
end
[/lua]
[B]Hook[/B]:
[lua]
function GM:PlayerTouchedTile(ply, tile)
...
end
[/lua]
Is this also considered bad practice?
I wanted to avoid calling secret, global functions from different parts of my code.
So I used hook.Run to call secret, global hooks from different parts of my code.
Keep the hook.Run/Call for others devs (if they want to make addons for your GM) and call your functions without using hooks.
[QUOTE=pierre0158;52547377]Keep the hook.Run/Call for others devs (if they want to make addons for your GM) and call your functions without using hooks.[/QUOTE]
Nitpicking like you are is an obvious sign of jealousy and pretty unsightly to be honest.
My gamemode is built to be modular so others can edit it with ease.
If i were to override the default gmod hooks then when someone wanted to add something they would need to check every single file to find references to what they want to do.
If you are even half as competent at reading other peoples code as you make out to be, you would understand that from the file structure and way things are laid out.
I used hooks as frequently as I did to try to keep each functional part of the gamemode its own, distinct module. Yknow, keeping everything loosely coupled, so I (or any other programmer) could easily add or remove stuff. Some of them were custom hooks, some were native. I even used hooks temporarily for some tasks, like the intro animation, and then just used hook.Remove after the animation was done.
Obviously we were more interested in people making a fun experience, but clearly you were more interested in being a party pooper and try to shit on their code.
It was a competition to make interesting and fun gamemodes, not be a perfect developer.
Go look at GameJams and realize that the code there isn't perfect either, it's about in a limited time making something exciting.
[QUOTE=pierre0158;52547377]Keep the hook.Run/Call for others devs (if they want to make addons for your GM) and call your functions without using hooks.[/QUOTE]
This is some lame microoptimization bullshit that won't change the outcome of anything. Stop whining because you didn't win or something, making hooks "Properly" literally doesn't change a single thing lmao
yes, of course you shouldn't use hooks if you intend to make gamamode..but there are a few cases where it does solve the problem. pierre0158 aka extremelapin is just fucking autistic that is all
*attacks code quality in a coding competition*
Since when does doing standard practices matter on rough drafts and prototypes? Usually you won't be starting off something new by following standard practices, you start following standards when you have something solid to work with. (though benefits to using hook.Add over global function hooks for gamemode code exist too, so it might not ever matter) And if you approach it as an optimization issue, given these are (some considerably polished ones I might add) prototypes which have only recently finished some of their gameplay implementations, you'd be wasting your time on optimizations, there is a saying in computing that goes something along the lines of "premature optimization is the root of all evil."
[QUOTE=pierre0158;52547377]Keep the hook.Run/Call for others devs (if they want to make addons for your GM) and call your functions without using hooks.[/QUOTE]
shut the fuck up you little bitch stop whining about the smallest things because of ur little jealousy issue
[highlight](User was banned for this post ("Flaming - Ban history" - Kiwi))[/highlight]
[QUOTE=pierre0158;52547118][img]http://i.imgur.com/NZCDEBO.png[/img]
[B]100%[/B] gmod hooks -> [DATA REQUIRED][/QUOTE]
m8 did you even [URL="https://github.com/Zet0rz/DATA-REQUIRED/search?utf8=%E2%9C%93&q=GM&type=Code"]try searching "GM"[/URL]? :v:
I don't use GM because I don't want to have to put all my logic in the same function. I want to be able to have my money-related Thinks in my money files and my player-related Thinks in my player files.
Also, some base gamemode GM functions have important functionality so overwriting them almost always requires something like self.BaseClass.PlayerSpawn(self,ply) or you'll break things.
The hook system is incredibly versatile and useful. There is no shame in utilizing it whenever possible. In fact, gamemodes which often call hook.Run() are among the most modular gamemodes around.
A little late on my part and irrelevant to the current bs about the pictures, but was this a tie?
[IMG]http://i.imgur.com/BLAGkLk.png[/IMG]
Edit:
Nevermind, I learned how to read. :D
[IMG]http://i.imgur.com/kSMPVDE.png[/IMG]
I'm really late on this, but congrats on winning, guys! I was personally rooting for Attack of the Mimics, really glad to see that it won 2nd place; again though, congrats to everyone else!
Hi, me again, I was under the impression that anyone who competed in any official contest would be getting facepunch gold or something like it? :pudge:
[QUOTE=raubana;52577879]Hi, me again, I was under the impression that anyone who competed in any official contest would be getting facepunch gold or something like it? :pudge:[/QUOTE]
Where did you hear that?
Also this isn't an official "Facepunch" competition.
[QUOTE=Nookyava;52577891]Where did you hear that?
Also this isn't an official "Facepunch" competition.[/QUOTE]
:downs: ... I can't find the source. Fuck. I swear I saw someone say something about it. Now I'm sad and feel stupid.
[editline]15th August 2017[/editline]
Although I suppose that point is moot since it's not even an official facepunch contest, goddamnit why the hell is it pinned :tableflip:
[QUOTE=raubana;52577921]:downs: ... I can't find the source. Fuck. I swear I saw someone say something about it. Now I'm sad and feel stupid.
[editline]15th August 2017[/editline]
Although I suppose that point is moot since it's not even an official facepunch contest, goddamnit why the hell is it pinned :tableflip:[/QUOTE]
It was pinned in order to help build notice for it.
[QUOTE=Nookyava;52577987]It was pinned in order to help build notice for it.[/QUOTE]
He's prob referencing to one of the older competitions where FP Gold was offer'd to winners too.
Sorry, you need to Log In to post a reply to this thread.
