[BUG] Crash any server by running 'test_workshop' in console

[tehbiga]

For people who are having the issues, try installing one of these that matches your system bitsies:
[URL="http://download.microsoft.com/download/5/B/C/5BC5DBB3-652D-4DCE-B14A-475AB85EEF6E/vcredist_x86.exe"]Microsoft Visual C++ 2010 Redistributable Package [B](x86)[/B][/URL]
[URL="http://download.microsoft.com/download/3/2/2/3224B87F-CFA0-4E70-BDA3-3DE650EFEBA5/vcredist_x64.exe"]Microsoft Visual C++ 2010 Redistributable Package [B](x64)[/B][/URL]

Time to sleep, been up for 28 hours. Good luck to the people having issues. If that fixes it I wonder if I can remove the dependency.

[kaos2100]

[QUOTE=Drakehawke;38226263][img]http://puu.sh/1jS2v[/img]

Wrote a quick binary to remove it since concommand.Remove/Add didn't work.

[editline]28th October 2012[/editline]

Windows version: [url]http://puu.sh/1jSSa[/url]

Save as gmsv_test_workshop_fix_win32.dll in garrysmod/lua/bin, require it serverside to remove it.

Source:

#define GMMODULE
#include "GarrysMod/Lua/Interface.h"

#include "tier1/tier1.h"
#include "tier1/interface.h"
#include "vstdlib/cvar.h"

GMOD_MODULE_OPEN()
{
	CreateInterfaceFn tier1Factory = VStdLib_GetICVarFactory();
	g_pCVar = (ICvar *)tier1Factory( CVAR_INTERFACE_VERSION, NULL );
	g_pCVar->UnregisterConCommand( g_pCVar->FindCommandBase( "test_workshop" ) );
	return 0;
}

Linux coming soon[/QUOTE]

Could you please release a linux version too?

[ptown2]

Actually, keep it. We're having a blast with the people using the command.

[IMG]https://dl.dropbox.com/u/6917336/screens/atelier.png[/IMG]

[kaos2100]

[QUOTE=ptown2;38257913]Actually, keep it. We're having a blast with the people using the command.

[IMG]https://dl.dropbox.com/u/6917336/screens/atelier.png[/IMG][/QUOTE]

How'd you get it to ban people for using the command?

[lorde banana]

slog maybe?

[koz]

I don't understand why this hasn't been patched yet, "officially."

[kulcris]

-snip-

[kaos2100]

[QUOTE=kulcris;38258376]linux binarys updated on the svn would be nice....[/QUOTE]

same... :( the latest svn doesn't work with linux.

Someone please help for linux.. T_T

[kulcris]

[QUOTE=garry;38232755]This is fixed in the SVN now. Servers should be able to replace their binaries with the binaries in the SVN to prevent the crash before the update goes out.[/QUOTE]
not for linux

[Ruzza]

[QUOTE=Banana Lord.;38258029]slog maybe?[/QUOTE]

concommand.Add maybe?

derp.

[kulcris]

L 10/31/2012 - 04:12:10: Lua Error: Couldn't include file 'includes/modules/cvar3
.lua' (File not found) (@lua/autorun/server/testworkshopfix.lua (line 3))

how in the world do i get cvar3 to work...

[Pantho]

[QUOTE=TehBigA;38256307]It has been patched already, but only in the SVN at the moment. Also I made sure I only build release because of the bugs it can sometimes cause.[/QUOTE]

Which seems to cause issues crashing when you ban users.

[kulcris]

...... just realized there is no linux build for cvar3.... so nvm looks like i will have to live with this problem until garry decides he wants to update the svn with linux servers in mind.... or an official patch is released

[Lexic]

Did your distro not come with gcc or something?

[Python1320]

[QUOTE=Lexic;38259987]Did your distro not come with gcc or something?[/QUOTE]

Python1320: !print cvars.GetCommand"test_workshop"
ConVar: 0xf3f55f40
Python1320: !print cvars.GetCommand"test_workshop":Remove()
*** glibc detected *** /home/srcds/srcds/orangebox/srcds_linux: free(): invalid pointer: 0xf3f55f40 ***

cvar3 doesn't still work too well with linux or I just suck at compiling. Gotta figure out what's going wrong.

[editline]31st October 2012[/editline]

Screw it, I'm busy so here's a quickfix: [url]http://g.iriz.uk.to/~srcds/modules/gm13/bin/[/url]
Grab gmsv_cvar3_linux.dll, stuff it in garrysmod/lua/bin
Make a lua file in autorun folder or somewhere.
Write this into it: [b]cvars.testshop()[/b]
That'll do exactly what the source on first page does.
Good luck.

[DontDoShit]

[QUOTE=ptown2;38257913]Actually, keep it. We're having a blast with the people using the command.

[IMG]https://dl.dropbox.com/u/6917336/screens/atelier.png[/IMG][/QUOTE]

i would like to request an unban :)

[Lexic]

I meant couldn't he just compile either Drakehawke or TehBigA's module for linux himself, but that works.

[JetBoom]

[QUOTE=kaos2100;38258005]How'd you get it to ban people for using the command?[/QUOTE]

Removed the cvar then made a Lua one with the same name that bans the sender. Thanks to our resident lau coder chewgum.

[Leystryku]

[QUOTE=JetBoom;38261122]Removed the cvar then made a Lua one with the same name that bans the sender. Thanks to our resident lau coder chewgum.[/QUOTE]

It's not good to do such thing though.
Imagine someone tells someone that the command is actually something useful and he believes it ?
He will get banned.

[profan]

[QUOTE=Leystryku;38261186]It's not good to do such thing though.
Imagine someone tells someone that the command is actually something useful and he believes it ?
He will get banned.[/QUOTE]

Good riddance? :v:

[zerothefallen]

[QUOTE=Python1320;38260155]

Python1320: !print cvars.GetCommand"test_workshop"
ConVar: 0xf3f55f40
Python1320: !print cvars.GetCommand"test_workshop":Remove()
*** glibc detected *** /home/srcds/srcds/orangebox/srcds_linux: free(): invalid pointer: 0xf3f55f40 ***

cvar3 doesn't still work too well with linux or I just suck at compiling. Gotta figure out what's going wrong.

[editline]31st October 2012[/editline]

Screw it, I'm busy so here's a quickfix: [url]http://g.iriz.uk.to/~srcds/modules/gm13/bin/[/url]
Grab gmsv_cvar3_linux.dll, stuff it in garrysmod/lua/bin
Make a lua file in autorun folder or somewhere.
Write this into it: [b]cvars.testshop()[/b]
That'll do exactly what the source on first page does.
Good luck.[/QUOTE]

[ERROR] lua/autorun/server/testworkshops.lua:1: attempt to call field 'testshop' (a nil value)
1. unknown - lua/autorun/server/testworkshops.lua:1

[editline]31st October 2012[/editline]

[QUOTE=JetBoom;38261122]Removed the cvar then made a Lua one with the same name that bans the sender. Thanks to our resident lau coder chewgum.[/QUOTE]
Can you send that to me via PM? That'd be very helpful to weed out bad people don'tcha think?

[Leystryku]

[QUOTE=Profanwolf;38261232]Good riddance? :v:[/QUOTE]

On one side it's good, you get rid of stupid players that don't think about opening something/typing something in console but on the other site it's quiet bad because they didn't know it bans them.

[psycix]

-snip-

EDIT: I stand corrected, this does NOT work.

[zerothefallen]

[QUOTE=psycix;38261430]Guys you don't need to use the module for this.
As stated earlier in this thread:
alias test_workshop ""
,works just fine. Just put it in the server.cfg.[/QUOTE]
This only works for the server, client still can crash it.

[Assault_Trooper]

[QUOTE=psycix;38261430]Guys you don't need to use the module for this.
As stated earlier in this thread:
alias test_workshop ""
,works just fine. Just put it in the server.cfg.[/QUOTE]

No it doesn't. The command still works on the client.

[psycix]

Just tested, you're right, so scratch that :)

[Dark Herald]

So radical but working fix for linux:

1. Grab server.so
2. Open in HEX editor.
3. Find by "test_workshop" and replace on "your_commands" or type zeros.
4. Profit :D

[initrd.gz]

[QUOTE=Dark Herald;38261770]So radical but working fix for linux:

1. Grab server.so
2. Open in HEX editor.
3. Find by "test_workshop" and replace on "your_commands" or type zeros.
4. Profit :D[/QUOTE]
Ewww.... >_>

I mean yea it works, but.... ew.

[Python1320]

[QUOTE=zerothefallen;38261253][ERROR] lua/autorun/server/testworkshops.lua:1: attempt to call field 'testshop' (a nil value)
1. unknown - lua/autorun/server/testworkshops.lua:1

[editline]31st October 2012[/editline]

Can you send that to me via PM? That'd be very helpful to weed out bad people don'tcha think?[/QUOTE]

I forgot, you also need to [I]require("cvar3")[/i] :v:

[editline]31st October 2012[/editline]

[QUOTE=initrd.gz;38261807]Ewww.... >_>

I mean yea it works, but.... ew.[/QUOTE]

Heh, I used to have a truckload of automatic binary pattern search and replaces with my server which were automatically applied after each update to patch some silly codes and such.
Hell, I even coded the patcher application since there was pretty much nothing like it for linux I was aware of and I was really getting tired of manual patching (offset patching would naturally not work).

[kulcris]

[QUOTE=Lexic;38260473]I meant couldn't he just compile either Drakehawke or TehBigA's module for linux himself, but that works.[/QUOTE]
shure if i had ANY idea how to even begin to compile something for linux...
thx python for that