[BUG] Crash any server by running 'test_workshop' in console

[Drakehawke]

[QUOTE=kulcris;38262800]shure if i had ANY idea how to even begin to compile something for linux...
thx python for that[/QUOTE]

I thought it would have been patched faster than this so the time figuring it out wouldn't have been worth it

[zerothefallen]

[QUOTE=Python1320;38261816]I forgot, you also need to [I]require("cvar3")[/i] :v:

[editline]31st October 2012[/editline]

thanks!

Heh, I used to have a truckload of automatic binary pattern search and replaces with my server which were automatically applied after each update to patch some silly codes and such.
Hell, I even coded the patcher application since there was pretty much nothing like it for linux I was aware of and I was really getting tired of manual patching (offset patching would naturally not work).[/QUOTE]

[kulcris]

[QUOTE=Dark Herald;38261770]So radical but working fix for linux:

1. Grab server.so
2. Open in HEX editor.
3. Find by "test_workshop" and replace on "your_commands" or type zeros.
4. Profit :D[/QUOTE]

this worked and was easy enough to implement thanks for that

[NinjaS]

I have an idea, remove the concommand and log and ban anyone that uses the test_workshop concommand

[lua]concommand.Add("test_workshop", function(ply) RunConsoleCommand("addip","0",ply:IpAddress()) RunConsoleCommand("writeip") end)
[/lua] Let the butt hurt flow threw!

[Drakehawke]

[QUOTE=NinjaS;38266310]I have an idea, remove the concommand and log and ban anyone that uses the test_workshop concommand

[lua]concommand.Add("test_workshop", function(ply) RunConsoleCommand("addip","0",ply:IpAddress()) RunConsoleCommand("writeip") end)
[/lua] Let the butt hurt flow threw![/QUOTE]

can't overwrite engine commands

[ptown2]

[QUOTE=Drakehawke;38266511]can't overwrite engine commands[/QUOTE]

But still you can either use both the alias or module method and use that to have fun banning retards.

[NinjaS]

[QUOTE=Drakehawke;38266511]can't overwrite engine commands[/QUOTE]

What if you remove it first. :dance:

[Drakehawke]

[QUOTE=NinjaS;38268598]What if you remove it first. :dance:[/QUOTE]

Ohh, in that case yeah you're right, you can

[kulcris]

fix for windows servers (server.dll and server.dylib)
fix for linux server (server.so )
take the corisponding files from this link (you can do all three if you want but its not needed.)
[url]http://mphx.net/fdl/testworkshopfix/[/url]
upload to your garrysmod/bin folder on your server
restart server
test

please backup your original files before trying

i used the hex editor to fix the problem (suggested earlier)
this is the one thing i will probably ever contribute to the community XD

edit (updated information and fixed link name)

[A_Pigeon]

Most useful command to date.

[ShaunOfTheLive]

[QUOTE=garry;38232755]This is fixed in the SVN now. Servers should be able to replace their binaries with the binaries in the SVN to prevent the crash before the update goes out.[/QUOTE]

Yeah, it prevents the exploit... by crashing immediately on startup instead.

[editline]31st October 2012[/editline]

[QUOTE=kulcris;38269004]Untested fix for windows servers..... will upload the linux one (tested and works) later tonight.... pretty much just did the hex editor on these files....

[url]http://mphx.net/fdl/testworkskopfix/[/url]

i edited these at work on my phone so again they may not work. please back up your original files before trying

let me know if it works please[/QUOTE]

Yeah, that works. Thanks.

[kulcris]

[QUOTE=ShaunOfTheLive;38269984]Yeah, it prevents the exploit... by crashing immediately on startup instead.

[editline]31st October 2012[/editline]

Yeah, that works. Thanks.[/QUOTE]

[QUOTE=kulcris;38269004]fix for windows servers (server.dll and server.dylib)
fix for linux server (server.so )
take the corisponding files from this link (you can do all three if you want but its not needed.)
[url]http://mphx.net/fdl/testworkshopfix/[/url]
upload to your garrysmod/bin folder on your server
restart server
test

please backup your original files before trying

i used the hex editor to fix the problem (suggested earlier)
this is the one thing i will probably ever contribute to the community XD

edit (updated information and fixed link name)[/QUOTE]

link has been changed due to my crappy spelling new link is in my original post

Also no crash on mapchange? :P

[kaos2100]

I think the gm13 svn has been updated with latest linux build.

[atkjack]

I get this error when im trying to start up gmod NOT a gmod server

[highlight](User was banned for this post ("Dumb bump" - Gran PC))[/highlight]