Pointshop preview broken?

Since the last Garry’s Mod update today, for some reason i can’t see item preview in 3d. Only 2d textures for trails are working fine… Everything else is broken. I’ve tried downloading original pointshop and it was still there.

Screenshot? Errors? Any other baddons?

There’s no errors but i can’t see item preview. That’s all.

Here are all the default items
http://s2.postimg.org/aufdthjh1/2015_06_01_00011.jpg

http://s2.postimg.org/9xe0hqead/2015_06_01_00012.jpg

http://s2.postimg.org/ifieoyehh/2015_06_01_00013.jpg

http://s2.postimg.org/pewgobefp/2015_06_01_00014.jpg

http://s2.postimg.org/6nuje5jv9/2015_06_01_00015.jpg

http://s2.postimg.org/t12a0ykt1/2015_06_01_00016.jpg

Getting this exact same problem!

Everything else is working fine though!

Thank you Garry for ruining Garry’s Mod again D:

Having same issue.

looking into it, not entirely sure what’s causing it though.

[editline]1st June 2015[/editline]

I suspect it’s something in here: pointshop/DPointShopItem.lua at master · adamdburton/pointshop · GitHub

am afk however so I can’t exactly test anything out right now, sorry guys!

[editline]1st June 2015[/editline]

if anyone figures out the solution, create a pull request here :slight_smile:

Thankyou so much Handsome Matt for looking for us though! :smiley:

http://forum.facepunch.com/showthread.php?t=1450721&p=47852595&viewfull=1#post47852595

pointshop already rewrites DModelPanel.Paint anyway so that pull request shouldn’t of effected it really.

Alrighty, I figured out what’s up.

The problem is that some addons override the default Paint function for DModelPanel and then call the old one, but they do not give the old functions the arguments of the Paint function call.

So, this:



	function DModelPanel:Paint()
			local x, y = self:LocalToScreen( 0, 0 )
			local w, h = self:GetSize()
			 
			local sl, st, sr, sb = x, y, x + w, y + h
			 
			local p = self
			while p:GetParent() do
				p = p:GetParent()
				local pl, pt = p:LocalToScreen( 0, 0 )
				local pr, pb = pl + p:GetWide(), pt + p:GetTall()
				sl = sl < pl and pl or sl
				st = st < pt and pt or st
				sr = sr > pr and pr or sr
				sb = sb > pb and pb or sb
			end
			 
			render.SetScissorRect( sl, st, sr, sb, true )
				oldPaint(self)
			render.SetScissorRect( 0, 0, 0, 0, false )
		end

Should be this:


	function DModelPanel:Paint(...)
			local x, y = self:LocalToScreen( 0, 0 )
			local w, h = self:GetSize()
			 
			local sl, st, sr, sb = x, y, x + w, y + h
			 
			local p = self
			while p:GetParent() do
				p = p:GetParent()
				local pl, pt = p:LocalToScreen( 0, 0 )
				local pr, pb = pl + p:GetWide(), pt + p:GetTall()
				sl = sl < pl and pl or sl
				st = st < pt and pt or st
				sr = sr > pr and pr or sr
				sb = sb > pb and pb or sb
			end
			 
			render.SetScissorRect( sl, st, sr, sb, true )
				oldPaint(self,...)
			render.SetScissorRect( 0, 0, 0, 0, false )
		end

[editline]1st June 2015[/editline]

Here’s the fix: https://github.com/adamdburton/pointshop/pull/213

Yep, that fixed it. Thanks!

that’s great robotboy, merged into master. :smile:

It worked Thankyou very much guys! :smiley:

Anyone else having trouble where some items are not always equipped? Pretty much everything else than playermodels seem to disappear at random just to get back later on my server. They are “equipped” but doesn’t show ingame.

-snip-